From: Joe Perches <joe@perches.com>
To: Mandeep Singh Baines <msb@chromium.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
olofj@chromium.org
Subject: Re: [PATCH] printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig
Date: Tue, 25 Jan 2011 17:15:14 -0800 [thread overview]
Message-ID: <1296004514.6115.16.camel@Joe-Laptop> (raw)
In-Reply-To: <20110126010137.GS8008@google.com>
On Tue, 2011-01-25 at 17:01 -0800, Mandeep Singh Baines wrote:
> Joe Perches (joe@perches.com) wrote:
> > On Tue, 2011-01-25 at 15:57 -0800, Mandeep Singh Baines wrote:
> > > To make it easier to audit dmesg, we'd like to make
> > > DEFAULT_MESSAGE_LEVEL Kconfig-settable. That way we can set it to
> > > KERN_NOTICE and audit any messages <= KERN_WARNING.
> > Seems sensible, but mightn't it be better to make sure
> > that all printks use a specific KERN_<level> rather
> > than check that printks without a KERN_<level> are
> > emitted at a selectable level?
> Can we do both?
As far as I'm concerned, yes.
> I was planning sending cleanup patches as well but expected
> that process to take a while.
True.
Perhaps you could do printk()->pr_<level> (dev_<level>/netdev_>level>)
conversions as appropriate as well.
> The correct thing would be to set each printk to an appropriate level.
> Determining appropriate level will take some discussion (so a long term
> project).
My EDC/ECD is: a long time from now. Maybe.
next prev parent reply other threads:[~2011-01-26 1:15 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 23:57 [PATCH] printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig Mandeep Singh Baines
2011-01-26 0:40 ` Joe Perches
2011-01-26 1:01 ` Mandeep Singh Baines
2011-01-26 1:15 ` Joe Perches [this message]
2011-01-26 4:18 ` WANG Cong
2011-01-26 23:05 ` Mandeep Baines
2011-01-27 5:49 ` WANG Cong
2011-01-26 22:49 ` Andrew Morton
2011-01-26 22:57 ` Randy Dunlap
2011-01-26 23:10 ` Andrew Morton
2011-01-27 7:26 ` WANG Cong
2011-01-27 8:27 ` Alexey Dobriyan
2011-01-27 15:57 ` Mandeep Singh Baines
2011-01-27 20:45 ` Ryan Mallon
2011-01-27 20:53 ` Alexey Dobriyan
2011-01-27 20:57 ` Ryan Mallon
2011-01-26 23:29 ` [PATCH v1 0/6] Set printk priority level Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-27 7:22 ` WANG Cong
2011-01-27 7:22 ` WANG Cong
2011-01-26 23:29 ` [PATCH 1/6] mm/page_alloc: use appropriate " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-27 0:32 ` Ryan Mallon
2011-01-27 0:32 ` Ryan Mallon
2011-01-27 4:22 ` Mandeep Singh Baines
2011-01-27 4:22 ` Mandeep Singh Baines
2011-01-27 4:22 ` Mandeep Singh Baines
2011-01-27 20:32 ` Ryan Mallon
2011-01-27 20:32 ` Ryan Mallon
2011-01-27 20:32 ` Ryan Mallon
2011-01-27 0:32 ` Ryan Mallon
2011-01-26 23:29 ` [PATCH 2/6] arch/x86: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 3/6] PM: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-31 10:12 ` Rafael J. Wysocki
2011-01-31 10:12 ` Rafael J. Wysocki
2011-01-31 10:12 ` Rafael J. Wysocki
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 4/6] TTY: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-02-03 22:13 ` Greg KH
2011-02-03 22:13 ` Greg KH
2011-02-03 22:13 ` Greg KH
2011-02-06 17:31 ` [PATCH v2] " Mandeep Singh Baines
2011-02-06 17:31 ` Mandeep Singh Baines
2011-02-06 17:31 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 4/6] " Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 5/6] fs: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 6/6] taskstats: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296004514.6115.16.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=msb@chromium.org \
--cc=olofj@chromium.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.