From: WANG Cong <xiyou.wangcong@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig
Date: Thu, 27 Jan 2011 07:26:12 +0000 (UTC) [thread overview]
Message-ID: <ihr6mk$qmm$4@dough.gmane.org> (raw)
In-Reply-To: 20110126151017.ed9e627c.akpm@linux-foundation.org
On Wed, 26 Jan 2011 15:10:17 -0800, Andrew Morton wrote:
> On Wed, 26 Jan 2011 14:57:03 -0800
> Randy Dunlap <rdunlap@xenotime.net> wrote:
>
>> > I'm a bit surprised that this wasn't already tunable at boot-time
>> > and/or at runtime.
>>
>>
>> As WANG Cong replied:
>>
>> Why? We already have "loglevel=" kernel parameter.
>
> That's different.
>
> Mandeep's patch addresses printks which didn't have a facility level.
> Longer-term, all these should be fixed, so they have an explicit
> facility level. I suppose that short-term it would make sense to prefer
> to blurt these messages onto the console rather than hiding them.
> Because they might be important. And if they weren't important, they
> will then irritate enough people to get themselves fixed.
Yeah, agreed. Actually checkpatch.pl will complain if a patch
contains a printk without KERN_*, this somewhat stops us having
more printk's without KERN_*.
Thanks.
next prev parent reply other threads:[~2011-01-27 7:30 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 23:57 [PATCH] printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig Mandeep Singh Baines
2011-01-26 0:40 ` Joe Perches
2011-01-26 1:01 ` Mandeep Singh Baines
2011-01-26 1:15 ` Joe Perches
2011-01-26 4:18 ` WANG Cong
2011-01-26 23:05 ` Mandeep Baines
2011-01-27 5:49 ` WANG Cong
2011-01-26 22:49 ` Andrew Morton
2011-01-26 22:57 ` Randy Dunlap
2011-01-26 23:10 ` Andrew Morton
2011-01-27 7:26 ` WANG Cong [this message]
2011-01-27 8:27 ` Alexey Dobriyan
2011-01-27 15:57 ` Mandeep Singh Baines
2011-01-27 20:45 ` Ryan Mallon
2011-01-27 20:53 ` Alexey Dobriyan
2011-01-27 20:57 ` Ryan Mallon
2011-01-26 23:29 ` [PATCH v1 0/6] Set printk priority level Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-27 7:22 ` WANG Cong
2011-01-27 7:22 ` WANG Cong
2011-01-26 23:29 ` [PATCH 1/6] mm/page_alloc: use appropriate " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-27 0:32 ` Ryan Mallon
2011-01-27 0:32 ` Ryan Mallon
2011-01-27 0:32 ` Ryan Mallon
2011-01-27 4:22 ` Mandeep Singh Baines
2011-01-27 4:22 ` Mandeep Singh Baines
2011-01-27 4:22 ` Mandeep Singh Baines
2011-01-27 20:32 ` Ryan Mallon
2011-01-27 20:32 ` Ryan Mallon
2011-01-27 20:32 ` Ryan Mallon
2011-01-26 23:29 ` [PATCH 2/6] arch/x86: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 3/6] PM: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-31 10:12 ` Rafael J. Wysocki
2011-01-31 10:12 ` Rafael J. Wysocki
2011-01-31 10:12 ` Rafael J. Wysocki
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 4/6] TTY: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-02-03 22:13 ` Greg KH
2011-02-03 22:13 ` Greg KH
2011-02-06 17:31 ` [PATCH v2] " Mandeep Singh Baines
2011-02-06 17:31 ` Mandeep Singh Baines
2011-02-06 17:31 ` Mandeep Singh Baines
2011-02-03 22:13 ` [PATCH 4/6] " Greg KH
2011-01-26 23:29 ` [PATCH 5/6] fs: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 6/6] taskstats: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ihr6mk$qmm$4@dough.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.