Re: [RFC][PATCH v3 3/6] encrypted-keys: add key format support

[Mimi Zohar <zohar@linux.vnet.ibm.com>]

On Wed, 2011-01-26 at 11:03 +0000, David Howells wrote:
> Roberto Sassu <roberto.sassu@polito.it> wrote:
> 
> > This patch introduces a new parameter, called 'format', that defines the
> > format of data stored by encrypted keys. The 'default' format identifies
> > encrypted keys containing only the symmetric key, while other formats can
> > be defined to support additional information. The 'format' parameter is
> > written in the datablob produced by commands 'keyctl print' or
> > 'keyctl pipe' and is integrity protected by the HMAC.
> 
> Would it make more sense to take key=val pairs where you have the <format>
> parameter?  Then you could have a format=default|foo|whatever argument and
> you'd leave room for future addition of qualifiers.
> 
> David

Either way it is extensible.  The current format is:

keyctl add encrypted name "new [format] key-type:master-key-name keylen" ring

As none of the other encrypted key parameters are defined as keypairs,
I'd prefer leaving the format option as it is.

thanks,

Mimi