From: David Howells <dhowells@redhat.com>
To: Roberto Sassu <roberto.sassu@polito.it>
Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org,
keyrings@linux-nfs.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, jmorris@namei.org,
zohar@linux.vnet.ibm.com, safford@watson.ibm.com,
ramunno@polito.it, tyhicks@linux.vnet.ibm.com,
kirkland@canonical.com
Subject: Re: [RFC][PATCH v3 2/6] encrypted-keys: added additional debug messages
Date: Wed, 26 Jan 2011 10:49:29 +0000 [thread overview]
Message-ID: <5456.1296038969@redhat.com> (raw)
In-Reply-To: <1295887497-20198-3-git-send-email-roberto.sassu@polito.it>
Roberto Sassu <roberto.sassu@polito.it> wrote:
> + pr_err("encrypted_key: insufficient parameters specified\n");
I think pr_err() is probably too high a message level. This is a user error
not a kernel error. I would recommend something like pr_info() or possibly
pr_debug().
David
next prev parent reply other threads:[~2011-01-26 10:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 16:44 [RFC][PATCH v3 0/6] eCryptfs: added support for the encrypted key type Roberto Sassu
2011-01-24 16:44 ` [RFC][PATCH v3 1/6] encrypted-keys: fixed valid_master_desc() function description Roberto Sassu
2011-01-26 11:05 ` David Howells
2011-01-24 16:44 ` [RFC][PATCH v3 2/6] encrypted-keys: added additional debug messages Roberto Sassu
2011-01-26 10:49 ` David Howells [this message]
2011-01-24 16:44 ` [RFC][PATCH v3 3/6] encrypted-keys: add key format support Roberto Sassu
2011-01-26 11:03 ` David Howells
2011-01-26 11:52 ` Mimi Zohar
2011-01-26 13:01 ` David Howells
2011-01-24 16:44 ` [RFC][PATCH v3 4/6] eCryptfs: export global eCryptfs definitions to include/linux/ecryptfs.h Roberto Sassu
2011-01-26 11:05 ` David Howells
2011-01-24 16:44 ` [RFC][PATCH v3 5/6] encrypted-keys: add ecryptfs format support Roberto Sassu
2011-01-25 22:57 ` Tyler Hicks
2011-01-26 11:18 ` David Howells
2011-01-26 12:57 ` Mimi Zohar
2011-01-24 16:44 ` [RFC][PATCH v3 6/6] eCryptfs: added support for the encrypted key type Roberto Sassu
2011-01-25 22:41 ` Tyler Hicks
2011-01-26 11:28 ` David Howells
2011-01-27 18:59 ` Roberto Sassu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5456.1296038969@redhat.com \
--to=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=keyrings@linux-nfs.org \
--cc=kirkland@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=ramunno@polito.it \
--cc=roberto.sassu@polito.it \
--cc=safford@watson.ibm.com \
--cc=tyhicks@linux.vnet.ibm.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.