* [PATCH] Enable Dell 5540 AGPS interface
@ 2011-01-28 4:56 Zhigang Li
2011-01-28 9:18 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Zhigang Li @ 2011-01-28 4:56 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
---
plugins/udev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/plugins/udev.c b/plugins/udev.c
index 202b225..ce1efe6 100644
--- a/plugins/udev.c
+++ b/plugins/udev.c
@@ -135,7 +135,7 @@ static void add_mbm(struct ofono_modem *modem,
devnode = udev_device_get_devnode(udev_device);
ofono_modem_set_string(modem, DATA_DEVICE, devnode);
} else if (g_str_has_suffix(desc, "Minicard GPS Port") ||
- g_str_has_suffix(desc, "Mini-Card GPRS Port") ||
+ g_str_has_suffix(desc, "Mini-Card GPS Port") ||
g_str_has_suffix(desc, "Broadband GPS Port")) {
devnode = udev_device_get_devnode(udev_device);
ofono_modem_set_string(modem, GPS_DEVICE, devnode);
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Enable Dell 5540 AGPS interface
2011-01-28 4:56 [PATCH] Enable Dell 5540 AGPS interface Zhigang Li
@ 2011-01-28 9:18 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2011-01-28 9:18 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
Hi Zhigang,
> plugins/udev.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/plugins/udev.c b/plugins/udev.c
> index 202b225..ce1efe6 100644
> --- a/plugins/udev.c
> +++ b/plugins/udev.c
> @@ -135,7 +135,7 @@ static void add_mbm(struct ofono_modem *modem,
> devnode = udev_device_get_devnode(udev_device);
> ofono_modem_set_string(modem, DATA_DEVICE, devnode);
> } else if (g_str_has_suffix(desc, "Minicard GPS Port") ||
> - g_str_has_suffix(desc, "Mini-Card GPRS Port") ||
> + g_str_has_suffix(desc, "Mini-Card GPS Port") ||
> g_str_has_suffix(desc, "Broadband GPS Port")) {
> devnode = udev_device_get_devnode(udev_device);
> ofono_modem_set_string(modem, GPS_DEVICE, devnode);
this looks like a typo. Patch has been applied. Next please prefix the
subject of such a patch with udev:
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-28 9:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-28 4:56 [PATCH] Enable Dell 5540 AGPS interface Zhigang Li
2011-01-28 9:18 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.