diff for duplicates of <1296225364.5511.6.camel@sifl> diff --git a/a/1.txt b/N1/1.txt index ea0249b..1320978 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,7 +14,7 @@ On Fri, 2011-01-28 at 15:17 +0100, Julia Lawall wrote: > expression data; > @@ > -> if (data = NULL) { ... +> if (data == NULL) { ... > * genlmsg_cancel(..., data); > ... > return ...; @@ -44,7 +44,7 @@ If I'm wrong, feel free to enlighten me. > @@ -635,7 +635,7 @@ static int netlbl_cipsov4_listall_cb(struct cipso_v4_doi *doi_def, void *arg) > cb_arg->seq, &netlbl_cipsov4_gnl_family, > NLM_F_MULTI, NLBL_CIPSOV4_C_LISTALL); -> if (data = NULL) +> if (data == NULL) > - goto listall_cb_failure; > + return ret_val; > @@ -57,7 +57,7 @@ If I'm wrong, feel free to enlighten me. > @@ -452,7 +452,7 @@ static int netlbl_mgmt_listall_cb(struct netlbl_dom_map *entry, void *arg) > cb_arg->seq, &netlbl_mgmt_gnl_family, > NLM_F_MULTI, NLBL_MGMT_C_LISTALL); -> if (data = NULL) +> if (data == NULL) > - goto listall_cb_failure; > + return ret_val; > @@ -66,7 +66,7 @@ If I'm wrong, feel free to enlighten me. > @@ -617,7 +617,7 @@ static int netlbl_mgmt_protocols_cb(struct sk_buff *skb, > &netlbl_mgmt_gnl_family, NLM_F_MULTI, > NLBL_MGMT_C_PROTOCOLS); -> if (data = NULL) +> if (data == NULL) > - goto protocols_cb_failure; > + return ret_val; > @@ -79,7 +79,7 @@ If I'm wrong, feel free to enlighten me. > @@ -1141,7 +1141,7 @@ static int netlbl_unlabel_staticlist_gen(u32 cmd, > cb_arg->seq, &netlbl_unlabel_gnl_family, > NLM_F_MULTI, cmd); -> if (data = NULL) +> if (data == NULL) > - goto list_cb_failure; > + return ret_val; > diff --git a/a/content_digest b/N1/content_digest index 937167f..8d1af46 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01296224232-8115-2-git-send-email-julia@diku.dk\0" "From\0Paul Moore <paul.moore@hp.com>\0" "Subject\0Re: [PATCH 2/2] net/netlabel: Avoid call to genlmsg_cancel\0" - "Date\0Fri, 28 Jan 2011 14:36:04 +0000\0" + "Date\0Fri, 28 Jan 2011 09:36:04 -0500\0" "To\0Julia Lawall <julia@diku.dk>\0" "Cc\0kernel-janitors@vger.kernel.org" David S. Miller <davem@davemloft.net> @@ -25,7 +25,7 @@ "> expression data;\n" "> @@\n" "> \n" - "> if (data = NULL) { ...\n" + "> if (data == NULL) { ...\n" "> * genlmsg_cancel(..., data);\n" "> ...\n" "> return ...;\n" @@ -55,7 +55,7 @@ "> @@ -635,7 +635,7 @@ static int netlbl_cipsov4_listall_cb(struct cipso_v4_doi *doi_def, void *arg)\n" "> \t\t\t cb_arg->seq, &netlbl_cipsov4_gnl_family,\n" "> \t\t\t NLM_F_MULTI, NLBL_CIPSOV4_C_LISTALL);\n" - "> \tif (data = NULL)\n" + "> \tif (data == NULL)\n" "> -\t\tgoto listall_cb_failure;\n" "> +\t\treturn ret_val;\n" "> \n" @@ -68,7 +68,7 @@ "> @@ -452,7 +452,7 @@ static int netlbl_mgmt_listall_cb(struct netlbl_dom_map *entry, void *arg)\n" "> \t\t\t cb_arg->seq, &netlbl_mgmt_gnl_family,\n" "> \t\t\t NLM_F_MULTI, NLBL_MGMT_C_LISTALL);\n" - "> \tif (data = NULL)\n" + "> \tif (data == NULL)\n" "> -\t\tgoto listall_cb_failure;\n" "> +\t\treturn ret_val;\n" "> \n" @@ -77,7 +77,7 @@ "> @@ -617,7 +617,7 @@ static int netlbl_mgmt_protocols_cb(struct sk_buff *skb,\n" "> \t\t\t &netlbl_mgmt_gnl_family, NLM_F_MULTI,\n" "> \t\t\t NLBL_MGMT_C_PROTOCOLS);\n" - "> \tif (data = NULL)\n" + "> \tif (data == NULL)\n" "> -\t\tgoto protocols_cb_failure;\n" "> +\t\treturn ret_val;\n" "> \n" @@ -90,7 +90,7 @@ "> @@ -1141,7 +1141,7 @@ static int netlbl_unlabel_staticlist_gen(u32 cmd,\n" "> \t\t\t cb_arg->seq, &netlbl_unlabel_gnl_family,\n" "> \t\t\t NLM_F_MULTI, cmd);\n" - "> \tif (data = NULL)\n" + "> \tif (data == NULL)\n" "> -\t\tgoto list_cb_failure;\n" "> +\t\treturn ret_val;\n" "> \n" @@ -102,4 +102,4 @@ "paul moore\n" linux @ hp -ba172bf3159aa83e74794145c3e2bfe966be5ddd91f78156f4109ad1abc2a285 +6256fea411833316711067f0ba132474ccfc1bf58b1b0cd11e7831d1128be91a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.