[PATCH] drm/nouveau: correctly pair hwmon_init and hwmon_fini

[PATCH] drm/nouveau: correctly pair hwmon_init and hwmon_fini

[Lucas Stach]

[-- Attachment #1: Type: text/plain, Size: 113 bytes --]

Hi Ben,

please push. This fixes
https://bugs.freedesktop.org/show_bug.cgi?id=33434 where I messed up.

-- Lucas

[-- Attachment #2: 0001-drm-nouveau-correctly-pair-hwmon_init-and-hwmon_fini.patch --]
[-- Type: text/x-patch, Size: 1044 bytes --]

From 996f1a11521a1b5b71e82b24e388a03f2f7ae2c2 Mon Sep 17 00:00:00 2001
From: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
Date: Sun, 30 Jan 2011 10:54:11 +0100
Subject: [PATCH] drm/nouveau: correctly pair hwmon_init and hwmon_fini

I broke this with my commit
07cfe0e7a820ecad078c04e9c2a102521709145d

This fixes fdo #33434

Signed-off-by: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
---
 drivers/gpu/drm/nouveau/nouveau_pm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_pm.c b/drivers/gpu/drm/nouveau/nouveau_pm.c
index fb846a3..f05c0cd 100644
--- a/drivers/gpu/drm/nouveau/nouveau_pm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_pm.c
@@ -443,7 +443,7 @@ nouveau_hwmon_fini(struct drm_device *dev)
 	struct nouveau_pm_engine *pm = &dev_priv->engine.pm;
 
 	if (pm->hwmon) {
-		sysfs_remove_group(&pm->hwmon->kobj, &hwmon_attrgroup);
+		sysfs_remove_group(&dev->pdev->dev.kobj, &hwmon_attrgroup);
 		hwmon_device_unregister(pm->hwmon);
 	}
 #endif
-- 
1.7.3.5


[-- Attachment #3: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [PATCH] drm/nouveau: correctly pair hwmon_init and hwmon_fini

[Ben Skeggs]

On Sun, 2011-01-30 at 11:06 +0100, Lucas Stach wrote:
> Hi Ben,
> 
Hey Lucas,

Thanks, pushed :)

Ben.
> please push. This fixes
> https://bugs.freedesktop.org/show_bug.cgi?id=33434 where I messed up.
> 
> -- Lucas