From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mathias Krause <minipli@googlemail.com>
Cc: Joern Engel <joern@lazybastard.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: fix memory leak
Date: Sun, 30 Jan 2011 16:52:33 +0200 [thread overview]
Message-ID: <1296399153.2388.57.camel@localhost> (raw)
In-Reply-To: <1296379908-10150-1-git-send-email-minipli@googlemail.com>
Hi,
On Sun, 2011-01-30 at 10:31 +0100, Mathias Krause wrote:
> diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
> index 5239328..8d28fa0 100644
> --- a/drivers/mtd/devices/phram.c
> +++ b/drivers/mtd/devices/phram.c
> @@ -117,6 +117,7 @@ static void unregister_devices(void)
> list_for_each_entry_safe(this, safe, &phram_list, list) {
> del_mtd_device(&this->mtd);
> iounmap(this->mtd.priv);
> + kfree(this->mtd.name);
> kfree(this);
> }
Since register_device() did not allocate it, unregister_devices() should
not free it. Hence, I think it is better to free(name) just after
calling unregister_devices().
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mathias Krause <minipli@googlemail.com>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Joern Engel <joern@lazybastard.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: fix memory leak
Date: Sun, 30 Jan 2011 16:52:33 +0200 [thread overview]
Message-ID: <1296399153.2388.57.camel@localhost> (raw)
In-Reply-To: <1296379908-10150-1-git-send-email-minipli@googlemail.com>
Hi,
On Sun, 2011-01-30 at 10:31 +0100, Mathias Krause wrote:
> diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
> index 5239328..8d28fa0 100644
> --- a/drivers/mtd/devices/phram.c
> +++ b/drivers/mtd/devices/phram.c
> @@ -117,6 +117,7 @@ static void unregister_devices(void)
> list_for_each_entry_safe(this, safe, &phram_list, list) {
> del_mtd_device(&this->mtd);
> iounmap(this->mtd.priv);
> + kfree(this->mtd.name);
> kfree(this);
> }
Since register_device() did not allocate it, unregister_devices() should
not free it. Hence, I think it is better to free(name) just after
calling unregister_devices().
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-01-30 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-30 9:31 [PATCH] mtd: fix memory leak Mathias Krause
2011-01-30 9:31 ` Mathias Krause
2011-01-30 14:52 ` Artem Bityutskiy [this message]
2011-01-30 14:52 ` Artem Bityutskiy
2011-01-30 17:35 ` Mathias Krause
2011-01-30 17:35 ` Mathias Krause
2011-02-06 15:08 ` Artem Bityutskiy
2011-02-06 15:08 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296399153.2388.57.camel@localhost \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=minipli@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.