All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
	alsa-devel@alsa-project.org,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc: neo1973_wm8753 audio support does	not require scoop
Date: Mon, 31 Jan 2011 12:05:04 +0000	[thread overview]
Message-ID: <1296475504.3316.46.camel@odin> (raw)
In-Reply-To: <20110131112339.GD11937@sirena.org.uk>

On Mon, 2011-01-31 at 11:23 +0000, Mark Brown wrote:
> On Fri, Jan 28, 2011 at 12:00:18PM -0700, H Hartley Sweeten wrote:
> > This driver does not use any of the functionality provided by the scoop
> > hardware.  Remove the unneeded header.
> > 
> > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> 
> CCing in Liam.  As I think I've mentioned before please do remember to
> CC maintainers.
> 
> > 
> > ---
> > 
> > diff --git a/sound/soc/samsung/neo1973_wm8753.c b/sound/soc/samsung/neo1973_wm8753.c
> > index c7a2451..c5b3113 100644
> > --- a/sound/soc/samsung/neo1973_wm8753.c
> > +++ b/sound/soc/samsung/neo1973_wm8753.c
> > @@ -24,7 +24,6 @@
> >  #include <sound/tlv.h>
> >  
> >  #include <asm/mach-types.h>
> > -#include <asm/hardware/scoop.h>
> >  #include <mach/regs-clock.h>
> >  #include <mach/regs-gpio.h>
> >  #include <mach/hardware.h>


Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

WARNING: multiple messages have this Message-ID (diff)
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
	alsa-devel@alsa-project.org,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] soc: neo1973_wm8753 audio support does not require scoop
Date: Mon, 31 Jan 2011 12:05:04 +0000	[thread overview]
Message-ID: <1296475504.3316.46.camel@odin> (raw)
In-Reply-To: <20110131112339.GD11937@sirena.org.uk>

On Mon, 2011-01-31 at 11:23 +0000, Mark Brown wrote:
> On Fri, Jan 28, 2011 at 12:00:18PM -0700, H Hartley Sweeten wrote:
> > This driver does not use any of the functionality provided by the scoop
> > hardware.  Remove the unneeded header.
> > 
> > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> 
> CCing in Liam.  As I think I've mentioned before please do remember to
> CC maintainers.
> 
> > 
> > ---
> > 
> > diff --git a/sound/soc/samsung/neo1973_wm8753.c b/sound/soc/samsung/neo1973_wm8753.c
> > index c7a2451..c5b3113 100644
> > --- a/sound/soc/samsung/neo1973_wm8753.c
> > +++ b/sound/soc/samsung/neo1973_wm8753.c
> > @@ -24,7 +24,6 @@
> >  #include <sound/tlv.h>
> >  
> >  #include <asm/mach-types.h>
> > -#include <asm/hardware/scoop.h>
> >  #include <mach/regs-clock.h>
> >  #include <mach/regs-gpio.h>
> >  #include <mach/hardware.h>


Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk


  reply	other threads:[~2011-01-31 12:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-28 19:00 [PATCH] soc: neo1973_wm8753 audio support does not require scoop H Hartley Sweeten
2011-01-28 19:00 ` H Hartley Sweeten
2011-01-31 11:23 ` Mark Brown
2011-01-31 11:23   ` [alsa-devel] " Mark Brown
2011-01-31 12:05   ` Liam Girdwood [this message]
2011-01-31 12:05     ` Liam Girdwood
2011-01-31 13:36 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296475504.3316.46.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=hartleys@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.