From: Stephen Smalley <sds@tycho.nsa.gov>
To: Lucian Adrian Grijincu <lucian.grijincu@gmail.com>
Cc: James Morris <jmorris@namei.org>,
Eric Paris <eparis@parisplace.org>,
Al Viro <viro@zeniv.linux.org.uk>, Christoph Hellwig <hch@lst.de>,
Dave Chinner <dchinner@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
selinux <selinux@tycho.nsa.gov>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH 2/2] RFC: selinux: sysctl: fix selinux labeling broken by last patch
Date: Mon, 31 Jan 2011 13:35:40 -0500 [thread overview]
Message-ID: <1296498940.26427.42.camel@moss-pluto> (raw)
In-Reply-To: <AANLkTi=3z-en0HAgVx1hRKrj6KYOHi_ZUP4aDv=8zUaa@mail.gmail.com>
On Mon, 2011-01-31 at 19:03 +0200, Lucian Adrian Grijincu wrote:
> On Mon, Jan 31, 2011 at 6:59 PM, Stephen Smalley <sds@tycho.nsa.gov> wrote:
> > /proc/sys inode labeling was disabled earlier (hence marked S_PRIVATE)
> > when /proc/sys was reimplemented by Eric, so all access control
> > on /proc/sys was switched to using the sysctl hook rather than the
> > inode-based checking. That's why you don't get a result from ls -Z
> > on /proc/sys on current kernels. Getting actual labeling working again
> > for those inodes would be a win, so your patch is an improvement in that
> > regard for selinux.
>
>
> Oh, OK. Thanks for letting me know.
>
> Do you see anything else that is wrong with these patches (apart from
> "//deleted")?
No, although I think someone should take them for a spin on a modern
Fedora in enforcing mode for a bit, and likely run the selinux testsuite
too.
--
Stephen Smalley
National Security Agency
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Smalley <sds@tycho.nsa.gov>
To: Lucian Adrian Grijincu <lucian.grijincu@gmail.com>
Cc: James Morris <jmorris@namei.org>,
Eric Paris <eparis@parisplace.org>,
Al Viro <viro@zeniv.linux.org.uk>, Christoph Hellwig <hch@lst.de>,
Dave Chinner <dchinner@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
selinux <selinux@tycho.nsa.gov>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH 2/2] RFC: selinux: sysctl: fix selinux labeling broken by last patch
Date: Mon, 31 Jan 2011 13:35:40 -0500 [thread overview]
Message-ID: <1296498940.26427.42.camel@moss-pluto> (raw)
In-Reply-To: <AANLkTi=3z-en0HAgVx1hRKrj6KYOHi_ZUP4aDv=8zUaa@mail.gmail.com>
On Mon, 2011-01-31 at 19:03 +0200, Lucian Adrian Grijincu wrote:
> On Mon, Jan 31, 2011 at 6:59 PM, Stephen Smalley <sds@tycho.nsa.gov> wrote:
> > /proc/sys inode labeling was disabled earlier (hence marked S_PRIVATE)
> > when /proc/sys was reimplemented by Eric, so all access control
> > on /proc/sys was switched to using the sysctl hook rather than the
> > inode-based checking. That's why you don't get a result from ls -Z
> > on /proc/sys on current kernels. Getting actual labeling working again
> > for those inodes would be a win, so your patch is an improvement in that
> > regard for selinux.
>
>
> Oh, OK. Thanks for letting me know.
>
> Do you see anything else that is wrong with these patches (apart from
> "//deleted")?
No, although I think someone should take them for a spin on a modern
Fedora in enforcing mode for a bit, and likely run the selinux testsuite
too.
--
Stephen Smalley
National Security Agency
next prev parent reply other threads:[~2011-01-31 18:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 3:26 [PATCH 2/2] RFC: selinux: sysctl: fix selinux labeling broken by last patch Lucian Adrian Grijincu
2011-01-31 13:59 ` Stephen Smalley
2011-01-31 13:59 ` Stephen Smalley
2011-01-31 14:14 ` Lucian Adrian Grijincu
2011-01-31 14:14 ` Lucian Adrian Grijincu
2011-01-31 14:21 ` Stephen Smalley
2011-01-31 14:21 ` Stephen Smalley
2011-01-31 16:27 ` Lucian Adrian Grijincu
2011-01-31 16:27 ` Lucian Adrian Grijincu
2011-01-31 16:59 ` Stephen Smalley
2011-01-31 16:59 ` Stephen Smalley
2011-01-31 17:03 ` Lucian Adrian Grijincu
2011-01-31 17:03 ` Lucian Adrian Grijincu
2011-01-31 18:35 ` Stephen Smalley [this message]
2011-01-31 18:35 ` Stephen Smalley
2011-01-31 19:55 ` Stephen Smalley
2011-01-31 19:55 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296498940.26427.42.camel@moss-pluto \
--to=sds@tycho.nsa.gov \
--cc=arnd@arndb.de \
--cc=dchinner@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eparis@parisplace.org \
--cc=hch@lst.de \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lucian.grijincu@gmail.com \
--cc=selinux@tycho.nsa.gov \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.