From: Johannes Berg <johannes@sipsolutions.net>
To: Vivek Natarajan <vnatarajan@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mac80211: Fix a race on enabling power save.
Date: Fri, 04 Feb 2011 14:07:29 +0100 [thread overview]
Message-ID: <1296824849.3671.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1296824755.3671.2.camel@jlt3.sipsolutions.net>
On Fri, 2011-02-04 at 14:05 +0100, Johannes Berg wrote:
> On Fri, 2011-02-04 at 17:55 +0530, Vivek Natarajan wrote:
>
> > + if (!(ieee80211_is_nullfunc(hdr->frame_control) &&
> > + ieee80211_has_pm(hdr->frame_control)) &&
> > + (ifmgd->flags & IEEE80211_STA_PS_PENDING))
> > + ifmgd->flags &= ~IEEE80211_STA_PS_PENDING;
> > +
>
> That's still just as broken before -- you can't assume ifmgd is valid
> here.
Err, never mind, I see you moved it.
johannes
next prev parent reply other threads:[~2011-02-04 13:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 12:25 [PATCH v2] mac80211: Fix a race on enabling power save Vivek Natarajan
2011-02-04 13:05 ` Johannes Berg
2011-02-04 13:07 ` Johannes Berg [this message]
2011-02-04 13:08 ` Johannes Berg
2011-02-04 13:12 ` Johannes Berg
2011-02-04 13:28 ` Vivek Natarajan
2011-02-04 14:08 ` Johannes Berg
2011-02-04 14:28 ` Vivek Natarajan
2011-02-15 14:28 ` Vivek Natarajan
2011-02-08 10:13 ` Vivek Natarajan
2011-02-15 12:44 ` Johannes Berg
2011-02-15 14:04 ` Vivek Natarajan
2011-02-15 14:09 ` Johannes Berg
2011-02-15 14:41 ` Vivek Natarajan
2011-02-16 9:31 ` Vivek Natarajan
2011-02-16 11:11 ` Johannes Berg
2011-02-16 12:28 ` Vivek Natarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296824849.3671.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vnatarajan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.