Re: [PATCH v2] mac80211: Fix a race on enabling power save.

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2011-02-16 at 15:01 +0530, Vivek Natarajan wrote:

> >> And this is how I understand this:
> >> stop queues, then send nullfunc, then do a flush to get the status and
> >> wake queues again irrespective of acked or not(but set the ACK_STATUS
> >> correspondingly). If tx() routine of nullfunc fails, then also wake
> >> the queues.
> >
> > Yes, but since the flush is there, the latter (tx fails, ...) won't be
> > needed.
> 
> If queues are stopped before sending nullfunc, it is added in the
> pending frames queue and the flush after nullfunc is ineffective. So,
> is it okay to bypass this queue_stop check with REASON_PS if it is a
> nullfunc frame? Any more ideas will be helpful.

Ah, but I wasn't thinking of stopping the device queues, just the sdata
queues, and the nullfunc doesn't go across those.

johannes