From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Dan Carpenter <error27@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ALSA: soc-cache: dereferencing before checking
Date: Mon, 07 Feb 2011 19:11:53 +0000 [thread overview]
Message-ID: <1297105913.3331.356.camel@odin> (raw)
In-Reply-To: <20110207190141.GJ4384@bicker>
On Mon, 2011-02-07 at 22:01 +0300, Dan Carpenter wrote:
> The patch c358e640a66 "ASoC: soc-cache: Add trace event for
> snd_soc_cache_sync()" introduced a dereference of "codec->cache_ops"
> before we had checked it for NULL.
>
> I pulled the check forward, and then pulled everything in an indent
> level.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
WARNING: multiple messages have this Message-ID (diff)
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Dan Carpenter <error27@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
kernel-janitors@vger.kernel.org
Subject: Re: [alsa-devel] [patch] ALSA: soc-cache: dereferencing before
Date: Mon, 07 Feb 2011 19:11:53 +0000 [thread overview]
Message-ID: <1297105913.3331.356.camel@odin> (raw)
In-Reply-To: <20110207190141.GJ4384@bicker>
On Mon, 2011-02-07 at 22:01 +0300, Dan Carpenter wrote:
> The patch c358e640a66 "ASoC: soc-cache: Add trace event for
> snd_soc_cache_sync()" introduced a dereference of "codec->cache_ops"
> before we had checked it for NULL.
>
> I pulled the check forward, and then pulled everything in an indent
> level.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2011-02-07 19:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 19:01 [patch] ALSA: soc-cache: dereferencing before checking Dan Carpenter
2011-02-07 19:01 ` Dan Carpenter
2011-02-07 19:11 ` Liam Girdwood [this message]
2011-02-07 19:11 ` [alsa-devel] [patch] ALSA: soc-cache: dereferencing before Liam Girdwood
2011-02-08 10:45 ` [patch] ALSA: soc-cache: dereferencing before checking Dimitris Papastamos
2011-02-08 10:45 ` [alsa-devel] [patch] ALSA: soc-cache: dereferencing before Dimitris Papastamos
2011-02-08 11:32 ` [patch] ALSA: soc-cache: dereferencing before checking Mark Brown
2011-02-08 11:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297105913.3331.356.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.