From: Matt Mackall <mpm@selenic.com>
To: Julia Lawall <julia@diku.dk>
Cc: Deepak Saxena <dsaxena@plexity.net>,
kernel-janitors@vger.kernel.org,
Herbert Xu <herbert@gondor.hengli.com.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] drivers/char/hw_random/omap-rng.c: Convert
Date: Mon, 14 Feb 2011 22:42:24 +0000 [thread overview]
Message-ID: <1297723344.5929.28.camel@calx> (raw)
In-Reply-To: <1297599132-7226-3-git-send-email-julia@diku.dk>
On Sun, 2011-02-13 at 13:12 +0100, Julia Lawall wrote:
> Request_region should be used with release_region, not release_resource.
>
> The local variable mem, storing the result of request_mem_region, is
> dropped and instead the pointer res is stored in the drvdata field of the
> platform device. This information is retrieved in omap_rng_remove to
> release the region. The drvdata field is not used elsewhere.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
Looks ok to me, Herbert?
--
Mathematics is the supreme nostalgia of our time.
WARNING: multiple messages have this Message-ID (diff)
From: Matt Mackall <mpm@selenic.com>
To: Julia Lawall <julia@diku.dk>
Cc: Deepak Saxena <dsaxena@plexity.net>,
kernel-janitors@vger.kernel.org,
Herbert Xu <herbert@gondor.hengli.com.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] drivers/char/hw_random/omap-rng.c: Convert release_resource to release_region/release_mem_region
Date: Mon, 14 Feb 2011 16:42:24 -0600 [thread overview]
Message-ID: <1297723344.5929.28.camel@calx> (raw)
In-Reply-To: <1297599132-7226-3-git-send-email-julia@diku.dk>
On Sun, 2011-02-13 at 13:12 +0100, Julia Lawall wrote:
> Request_region should be used with release_region, not release_resource.
>
> The local variable mem, storing the result of request_mem_region, is
> dropped and instead the pointer res is stored in the drvdata field of the
> platform device. This information is retrieved in omap_rng_remove to
> release the region. The drvdata field is not used elsewhere.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
Looks ok to me, Herbert?
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2011-02-14 22:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 11:50 [PATCH 0/5] Convert release_resource to release_region/release_mem_region Julia Lawall
2011-02-13 12:12 ` Julia Lawall
2011-02-13 11:50 ` [PATCH 1/5] drivers/i2c/busses/i2c-au1550.c: Convert release_resource to release_region/release_mem_ Julia Lawall
2011-02-13 12:12 ` [PATCH 1/5] drivers/i2c/busses/i2c-au1550.c: Convert release_resource to release_region/release_mem_region Julia Lawall
2011-02-13 11:51 ` [PATCH 3/5] drivers/char/pcmcia/ipwireless/main.c: Convert release_resource to release_region/releas Julia Lawall
2011-02-13 12:12 ` [PATCH 3/5] drivers/char/pcmcia/ipwireless/main.c: Convert release_resource to release_region/release_mem_region Julia Lawall
2011-02-16 7:21 ` [PATCH 3/5] drivers/char/pcmcia/ipwireless/main.c: Convert Dominik Brodowski
2011-02-16 7:21 ` [PATCH 3/5] drivers/char/pcmcia/ipwireless/main.c: Convert release_resource to release_region/release_mem_region Dominik Brodowski
2011-02-16 8:44 ` [PATCH 3/5] drivers/char/pcmcia/ipwireless/main.c: Convert Jiri Kosina
2011-02-16 8:44 ` [PATCH 3/5] drivers/char/pcmcia/ipwireless/main.c: Convert release_resource to release_region/release_mem_region Jiri Kosina
[not found] ` <1297599132-7226-1-git-send-email-julia-dAYI7NvHqcQ@public.gmane.org>
2011-02-13 11:51 ` [PATCH 5/5] drivers/i2c/busses/i2c-nuc900.c: Convert release_resource to release_region/release_mem_ Julia Lawall
2011-02-13 12:12 ` [PATCH 5/5] drivers/i2c/busses/i2c-nuc900.c: Convert release_resource to release_region/release_mem_region Julia Lawall
2011-02-13 12:12 ` Julia Lawall
[not found] ` <1297599132-7226-6-git-send-email-julia-dAYI7NvHqcQ@public.gmane.org>
2011-02-14 16:56 ` [PATCH 5/5] drivers/i2c/busses/i2c-nuc900.c: Convert release_resource to release_region/release_ Marek Vasut
2011-02-14 16:56 ` [PATCH 5/5] drivers/i2c/busses/i2c-nuc900.c: Convert release_resource to release_region/release_mem_region Marek Vasut
2011-02-14 16:56 ` Marek Vasut
[not found] ` <201102141756.19068.marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-02-14 17:04 ` [PATCH 5/5] drivers/i2c/busses/i2c-nuc900.c: Convert release_resource Julia Lawall
2011-02-14 17:04 ` [PATCH 5/5] drivers/i2c/busses/i2c-nuc900.c: Convert release_resource to release_region/release_mem_region Julia Lawall
2011-02-14 17:04 ` Julia Lawall
2011-02-13 11:51 ` [PATCH 4/5] arch/x86/pci/direct.c: " Julia Lawall
2011-02-13 12:12 ` Julia Lawall
2011-04-08 19:50 ` [PATCH 4/5] arch/x86/pci/direct.c: Convert release_resource to Jesse Barnes
2011-04-08 19:50 ` [PATCH 4/5] arch/x86/pci/direct.c: Convert release_resource to release_region/release_mem_region Jesse Barnes
2011-02-13 11:51 ` [PATCH 2/5] drivers/char/hw_random/omap-rng.c: Convert release_resource to release_region/release_me Julia Lawall
2011-02-13 12:12 ` [PATCH 2/5] drivers/char/hw_random/omap-rng.c: Convert release_resource to release_region/release_mem_region Julia Lawall
2011-02-14 22:42 ` Matt Mackall [this message]
2011-02-14 22:42 ` Matt Mackall
2011-02-14 22:47 ` [PATCH 2/5] drivers/char/hw_random/omap-rng.c: Convert Herbert Xu
2011-02-14 22:47 ` [PATCH 2/5] drivers/char/hw_random/omap-rng.c: Convert release_resource to release_region/release_mem_region Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297723344.5929.28.camel@calx \
--to=mpm@selenic.com \
--cc=dsaxena@plexity.net \
--cc=herbert@gondor.hengli.com.au \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.