From: "Michael Büsch" <mb@bu3sch.de>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: "John Linville" <linville@tuxdriver.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
b43-dev <b43-dev@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] ssb: Make ssb_wait_bit multi-bit safe
Date: Tue, 15 Feb 2011 01:20:01 +0100 [thread overview]
Message-ID: <1297729201.5683.22.camel@maggie> (raw)
In-Reply-To: <AANLkTingds9m3sj5bJoExiuoivbRSAtnF2A-4emjYMdJ@mail.gmail.com> (sfid-20110215_011145_942850_24C2EA9B)
On Tue, 2011-02-15 at 01:03 +0100, G?bor Stefanik wrote:
> > -static int ssb_wait_bit(struct ssb_device *dev, u16 reg, u32 bitmask,
> > - int timeout, int set)
> > +static int ssb_wait_bits(struct ssb_device *dev, u16 reg, u32 bitmask,
> > + int timeout, int set)
>
> While you are at it, you may want to change this to "bool set".
Please feel free to submit a separate patch on top of this.
--
Greetings Michael.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <mb@bu3sch.de>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: "John Linville" <linville@tuxdriver.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
b43-dev <b43-dev@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ssb: Make ssb_wait_bit multi-bit safe
Date: Tue, 15 Feb 2011 01:20:01 +0100 [thread overview]
Message-ID: <1297729201.5683.22.camel@maggie> (raw)
In-Reply-To: <AANLkTingds9m3sj5bJoExiuoivbRSAtnF2A-4emjYMdJ@mail.gmail.com> (sfid-20110215_011145_942850_24C2EA9B)
On Tue, 2011-02-15 at 01:03 +0100, Gábor Stefanik wrote:
> > -static int ssb_wait_bit(struct ssb_device *dev, u16 reg, u32 bitmask,
> > - int timeout, int set)
> > +static int ssb_wait_bits(struct ssb_device *dev, u16 reg, u32 bitmask,
> > + int timeout, int set)
>
> While you are at it, you may want to change this to "bool set".
Please feel free to submit a separate patch on top of this.
--
Greetings Michael.
next prev parent reply other threads:[~2011-02-15 0:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 23:21 [PATCH] ssb: Make ssb_wait_bit multi-bit safe Michael Büsch
2011-02-14 23:44 ` Rafał Miłecki
2011-02-14 23:44 ` Rafał Miłecki
2011-02-14 23:59 ` Michael Büsch
2011-02-14 23:59 ` Michael Büsch
2011-02-15 0:04 ` Rafał Miłecki
2011-02-15 0:04 ` Rafał Miłecki
2011-02-15 0:03 ` Gábor Stefanik
2011-02-15 0:03 ` Gábor Stefanik
2011-02-15 0:20 ` Michael Büsch [this message]
2011-02-15 0:20 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297729201.5683.22.camel@maggie \
--to=mb@bu3sch.de \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netrolller.3d@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.