From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Taneja, Archit" <archit@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Cousson, Benoit" <b-cousson@ti.com>
Subject: Re: [PATCH] OMAP: DSS2: Have separate irq handlers for DISPC and DSI
Date: Fri, 18 Feb 2011 13:11:37 +0200 [thread overview]
Message-ID: <1298027497.24062.53.camel@deskari> (raw)
In-Reply-To: <4D5E5275.4020002@ti.com>
On Fri, 2011-02-18 at 05:05 -0600, Taneja, Archit wrote:
> Hi,
>
<snip>
> One strange thing I see though is the increment with and without printks
> in the irq handler in both the cases. I always see increments of 2 when
> I put prints. I see 3 when I don't. That's a bit peculiar.
Hmm. That's probably because prints make it slower. TE_TRIGGER and
VC0_IRQ probably happen at different times. If you have printks, they
are combined into one interrupt. If no printk, the code is faster and
handles them separately.
> Behavior looks as expected. I guess we can go without DSS_IRQSTATUS
> then. Should I send out a patch? Also, should we remove DSS_IRQSTATUS in
> totality from the code now?
Ok. Yes, please send a patch. Is DSS_IRQSTATUS used anywhere after the
patch? I guess not. But let's leave the define there, as the register
still exists.
Tomi
next prev parent reply other threads:[~2011-02-18 11:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 14:25 [PATCH] OMAP: DSS2: Have separate irq handlers for DISPC and DSI Archit Taneja
2011-02-18 9:10 ` Valkeinen, Tomi
2011-02-18 9:34 ` archit taneja
2011-02-18 9:45 ` Turquette, Mike
2011-02-18 9:50 ` Tomi Valkeinen
2011-02-18 10:25 ` archit taneja
2011-02-18 10:00 ` Tomi Valkeinen
2011-02-18 11:05 ` archit taneja
2011-02-18 11:11 ` Tomi Valkeinen [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-21 6:00 Archit Taneja
2011-02-21 6:03 ` archit taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298027497.24062.53.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.