From: Artem Bityutskiy <dedekind1@gmail.com>
To: Tracey Dent <tdent48227@gmail.com>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/jffs2/xattr: Fix coding style
Date: Fri, 25 Feb 2011 12:51:14 +0200 [thread overview]
Message-ID: <1298631074.2798.51.camel@localhost> (raw)
In-Reply-To: <20110221093902.GA4759@linux-rdzc.hsd1.mi.comcast.net>
On Mon, 2011-02-21 at 04:39 -0500, Tracey Dent wrote:
> Remove the trailing white space and get rid of the
> unnessary {} on certain statements.
>
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Could you please do one change per patch?
Make first patch to only fix the trailing white-space issue. I'd take it
to my tree immediately. You can make the second patch which removes
unnecessary {}, but this patch would be arguable, I'm not sure I'd take
it.
In any case, now I should reject whole patch, but in the "one patch per
logical change" case I'd take at least part of your work.
Thanks a lot!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Tracey Dent <tdent48227@gmail.com>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/jffs2/xattr: Fix coding style
Date: Fri, 25 Feb 2011 12:51:14 +0200 [thread overview]
Message-ID: <1298631074.2798.51.camel@localhost> (raw)
In-Reply-To: <20110221093902.GA4759@linux-rdzc.hsd1.mi.comcast.net>
On Mon, 2011-02-21 at 04:39 -0500, Tracey Dent wrote:
> Remove the trailing white space and get rid of the
> unnessary {} on certain statements.
>
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Could you please do one change per patch?
Make first patch to only fix the trailing white-space issue. I'd take it
to my tree immediately. You can make the second patch which removes
unnecessary {}, but this patch would be arguable, I'm not sure I'd take
it.
In any case, now I should reject whole patch, but in the "one patch per
logical change" case I'd take at least part of your work.
Thanks a lot!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-02-25 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 9:39 [PATCH] fs/jffs2/xattr: Fix coding style Tracey Dent
2011-02-25 10:51 ` Artem Bityutskiy [this message]
2011-02-25 10:51 ` Artem Bityutskiy
-- strict thread matches above, loose matches on Subject: below --
2011-02-26 16:15 Tracey Dent
2011-02-26 16:15 ` Tracey Dent
2011-02-28 13:56 ` Artem Bityutskiy
2011-02-28 13:56 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298631074.2798.51.camel@localhost \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=tdent48227@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.