From: Artem Bityutskiy <dedekind1@gmail.com>
To: Jason Liu <r64343@freescale.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, David.Woodhouse@intel.com
Subject: Re: [PATCH] mtd: nand: fix one typo in the comments
Date: Fri, 25 Feb 2011 14:43:05 +0200 [thread overview]
Message-ID: <1298637785.2798.106.camel@localhost> (raw)
In-Reply-To: <1298610378-3105-1-git-send-email-r64343@freescale.com>
On Fri, 2011-02-25 at 13:06 +0800, Jason Liu wrote:
> In the function nand_do_write_oob, the comments
> has one typo, this patch fix it.
>
> - /* Do not allow reads past end of device */
> + /* Do not allow write past end of device */
> if (unlikely(to >= mtd->size ||
> ops->ooboffs + ops->ooblen >
> ((mtd->size >> chip->page_shift) -
> (to >> chip->page_shift)) * len)) {
> DEBUG(MTD_DEBUG_LEVEL0, "%s: Attempt write beyond "
> "end of device\n", __func__);
> return -EINVAL;
> }
>
> Signed-off-by: Jason Liu <r64343@freescale.com>
Oh, please, do not copy the patch into the commit message! It is enough
to say that you fix a typo in a commentary.
But I've amended the commit message and pushed the patch to my
l2-mtd-2.6.git tree, thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: nand: fix one typo in the comments
Date: Fri, 25 Feb 2011 14:43:05 +0200 [thread overview]
Message-ID: <1298637785.2798.106.camel@localhost> (raw)
In-Reply-To: <1298610378-3105-1-git-send-email-r64343@freescale.com>
On Fri, 2011-02-25 at 13:06 +0800, Jason Liu wrote:
> In the function nand_do_write_oob, the comments
> has one typo, this patch fix it.
>
> - /* Do not allow reads past end of device */
> + /* Do not allow write past end of device */
> if (unlikely(to >= mtd->size ||
> ops->ooboffs + ops->ooblen >
> ((mtd->size >> chip->page_shift) -
> (to >> chip->page_shift)) * len)) {
> DEBUG(MTD_DEBUG_LEVEL0, "%s: Attempt write beyond "
> "end of device\n", __func__);
> return -EINVAL;
> }
>
> Signed-off-by: Jason Liu <r64343@freescale.com>
Oh, please, do not copy the patch into the commit message! It is enough
to say that you fix a typo in a commentary.
But I've amended the commit message and pushed the patch to my
l2-mtd-2.6.git tree, thanks!
--
Best Regards,
Artem Bityutskiy (????? ????????)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Jason Liu <r64343@freescale.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
David.Woodhouse@intel.com
Subject: Re: [PATCH] mtd: nand: fix one typo in the comments
Date: Fri, 25 Feb 2011 14:43:05 +0200 [thread overview]
Message-ID: <1298637785.2798.106.camel@localhost> (raw)
In-Reply-To: <1298610378-3105-1-git-send-email-r64343@freescale.com>
On Fri, 2011-02-25 at 13:06 +0800, Jason Liu wrote:
> In the function nand_do_write_oob, the comments
> has one typo, this patch fix it.
>
> - /* Do not allow reads past end of device */
> + /* Do not allow write past end of device */
> if (unlikely(to >= mtd->size ||
> ops->ooboffs + ops->ooblen >
> ((mtd->size >> chip->page_shift) -
> (to >> chip->page_shift)) * len)) {
> DEBUG(MTD_DEBUG_LEVEL0, "%s: Attempt write beyond "
> "end of device\n", __func__);
> return -EINVAL;
> }
>
> Signed-off-by: Jason Liu <r64343@freescale.com>
Oh, please, do not copy the patch into the commit message! It is enough
to say that you fix a typo in a commentary.
But I've amended the commit message and pushed the patch to my
l2-mtd-2.6.git tree, thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-02-25 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 5:06 [PATCH] mtd: nand: fix one typo in the comments Jason Liu
2011-02-25 5:06 ` Jason Liu
2011-02-25 5:06 ` Jason Liu
2011-02-25 12:43 ` Artem Bityutskiy [this message]
2011-02-25 12:43 ` Artem Bityutskiy
2011-02-25 12:43 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298637785.2798.106.camel@localhost \
--to=dedekind1@gmail.com \
--cc=David.Woodhouse@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=r64343@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.