From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"Venkataraman, Meenakshi" <meenakshi.venkataraman@intel.com>,
"Berg, Johannes" <johannes.berg@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] iwlwifi: remove duplicate initialization
Date: Sat, 26 Feb 2011 05:01:01 +0000 [thread overview]
Message-ID: <1298696461.6478.1.camel@wwguy-huron> (raw)
In-Reply-To: <20110226015653.GC18043@bicker>
On Fri, 2011-02-25 at 17:56 -0800, Dan Carpenter wrote:
> rate_mask is initialized again later so this can be removed. Btw, if
> rate_control_send_low(sta, priv_sta, txrc) returns false, that means
> that "sta" is non-NULL. That's why the second initialization of
> rate_mask is a little simpler than the first.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
make sense
Wey
WARNING: multiple messages have this Message-ID (diff)
From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"Venkataraman, Meenakshi" <meenakshi.venkataraman@intel.com>,
"Berg, Johannes" <johannes.berg@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] iwlwifi: remove duplicate initialization
Date: Fri, 25 Feb 2011 21:01:01 -0800 [thread overview]
Message-ID: <1298696461.6478.1.camel@wwguy-huron> (raw)
In-Reply-To: <20110226015653.GC18043@bicker>
On Fri, 2011-02-25 at 17:56 -0800, Dan Carpenter wrote:
> rate_mask is initialized again later so this can be removed. Btw, if
> rate_control_send_low(sta, priv_sta, txrc) returns false, that means
> that "sta" is non-NULL. That's why the second initialization of
> rate_mask is a little simpler than the first.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
make sense
Wey
next prev parent reply other threads:[~2011-02-26 5:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 1:56 [patch] iwlwifi: remove duplicate initialization Dan Carpenter
2011-02-26 1:56 ` Dan Carpenter
2011-02-26 5:01 ` Guy, Wey-Yi [this message]
2011-02-26 5:01 ` Guy, Wey-Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298696461.6478.1.camel@wwguy-huron \
--to=wey-yi.w.guy@intel.com \
--cc=error27@gmail.com \
--cc=johannes.berg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=meenakshi.venkataraman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.