All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Stephane Eranian <eranian@google.com>
Cc: Lin Ming <ming.m.lin@intel.com>, Ingo Molnar <mingo@elte.hu>,
	Andi Kleen <andi@firstfloor.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] perf-events: Add support for supplementary event registers
Date: Wed, 02 Mar 2011 11:34:01 +0100	[thread overview]
Message-ID: <1299062041.1310.3.camel@laptop> (raw)
In-Reply-To: <AANLkTi=a3_EE8RwdRTmhpcgGwq2fY8jXMC=s+zwh7_NE@mail.gmail.com>

On Wed, 2011-03-02 at 08:48 +0100, Stephane Eranian wrote:
> >> >        __u32                   bp_type;
> >> > -       __u64                   bp_addr;
> >> > -       __u64                   bp_len;
> >> > +       union {
> >> > +               __u64           bp_addr;
> >> > +               __u64           config1; /* extension of config0 */
> >> > +       };
> >> > +       union {
> >> > +               __u64           bp_len;
> >> > +               __u64           config2; /* extension of config1 */
> >> > +       };
> >> >  };
> >> >
> >> I don't see where those config0 or config1 are coming from.
> >
> > config0 means perf_event_attr::config.
> >
> yes.
> 
> > Peter suggested to extend the attr config space.
> > http://marc.info/?l=linux-kernel&m=129838808907525&w=2
> >
> Ok, I get it, it is cascading. that's fine. 

I initially put config and config0 in a union, but that made compilation
fail and fixing that up vs the benefit of actually having a config0,
which seemed near 0, led me to drop that part. Forgot to update the
comment though ;-)


  reply	other threads:[~2011-03-02 10:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01 16:47 [PATCH v2 1/4] perf-events: Add support for supplementary event registers Lin Ming
2011-03-01 17:09 ` Stephane Eranian
2011-03-02  0:37   ` Lin Ming
2011-03-02  7:48     ` Stephane Eranian
2011-03-02 10:34       ` Peter Zijlstra [this message]
2011-03-02 12:07         ` Stephane Eranian
2011-03-02 12:29           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299062041.1310.3.camel@laptop \
    --to=a.p.zijlstra@chello.nl \
    --cc=andi@firstfloor.org \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.