All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/3] iwlwifi: avoid too frequent recover from statistics
Date: Fri, 04 Mar 2011 08:46:26 -0800	[thread overview]
Message-ID: <1299257186.5082.139.camel@wwguy-huron> (raw)
In-Reply-To: <1299257511-5241-3-git-send-email-sgruszka@redhat.com>

Hi Stanislaw,

On Fri, 2011-03-04 at 08:51 -0800, Stanislaw Gruszka wrote:
> Usually H/W generate statistics notify once per about 100ms, but
> sometimes we can receive notify in shorter time, even 2 ms.
> 
> This can be problem for plcp health and ack health checking.
> 
> I.e. with 2 plcp errors happens randomly in 2 ms duration, we
> exceed plcp delta threshold equal to 100 (2*100/2).
> 
> Also checking ack's in short time, can results not necessary false
> positive and firmware reset, for example when channel is noised and
> we do not receive ACKs frames or when remote device does not send
> ACKs at the moment.
> 
> Patch change code to do statistic check and possible recovery only
> if 99ms elapsed from last check. Forced delay should assure we have
> good statistic data to estimate hardware state.
> 
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>

this plcp and ack count getting really complicate and not sure really
worth doing it? but ok for now

Wey


  reply	other threads:[~2011-03-04 17:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-04 16:51 [PATCH 1/3] iwlwifi: move rx handlers code to iwl-rx.c Stanislaw Gruszka
2011-03-04 16:51 ` [PATCH 2/3] iwlwifi: cleanup iwl_good_plcp_health Stanislaw Gruszka
2011-03-04 16:47   ` Guy, Wey-Yi
2011-03-04 16:51 ` [PATCH 3/3] iwlwifi: avoid too frequent recover from statistics Stanislaw Gruszka
2011-03-04 16:46   ` Guy, Wey-Yi [this message]
2011-03-04 16:52 ` [PATCH 1/3] iwlwifi: move rx handlers code to iwl-rx.c Guy, Wey-Yi
2011-03-06 21:34 ` Guy, Wey-Yi
2011-03-06 23:47   ` Daniel Halperin
2011-03-07  8:12     ` Undefined TASK_INTERRUPTIBLE (Was: Re: [PATCH 1/3] iwlwifi: move rx handlers code to iwl-rx.c) Stanislaw Gruszka
2011-03-07  9:20       ` Peter Zijlstra
2011-03-07 13:12         ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299257186.5082.139.camel@wwguy-huron \
    --to=wey-yi.w.guy@intel.com \
    --cc=ilw@linux.intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.