From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Daniel Halperin <dhalperi@cs.washington.edu>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>
Cc: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Undefined TASK_INTERRUPTIBLE (Was: Re: [PATCH 1/3] iwlwifi: move rx handlers code to iwl-rx.c)
Date: Mon, 7 Mar 2011 09:12:45 +0100 [thread overview]
Message-ID: <20110307081241.GA2216@redhat.com> (raw)
In-Reply-To: <AANLkTimNjxguAFcRr-mJr-pPMkf6zTxzm4k7oV+6zngG@mail.gmail.com>
On Sun, Mar 06, 2011 at 03:47:55PM -0800, Daniel Halperin wrote:
> This fixes the error for me.
Code compile on 64 bits, but fail on 32, hmm ...
> Dan
>
> index 7dc2d39..e3ba4d5 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-rx.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-rx.c
> @@ -30,6 +30,7 @@
> #include <linux/etherdevice.h>
> #include <linux/slab.h>
> #include <net/mac80211.h>
> +#include <linux/sched.h>
> #include <asm/unaligned.h>
> #include "iwl-eeprom.h"
> #include "iwl-dev.h"
This fixes the problem, I will post signed-off patch to John in
a second.
But perhaps we need a more generic fix in wait.h for the future. Maybe
we should decouple definitions of TASK_INTERRUPTIBLE and friends from
sched.h into separate header and include that header in wait.h as well?
Stanislaw
> On Sun, Mar 6, 2011 at 1:34 PM, Guy, Wey-Yi <wey-yi.w.guy@intel.com> wrote:
> > Hi Stanislaw,
> >
> > On Fri, 2011-03-04 at 08:51 -0800, Stanislaw Gruszka wrote:
> >> Put generic rx_handlers (except iwlagn_rx_reply_compressed_ba) to
> >> iwl-rx.c . Make functions static and change prefix from iwlagn_ to
> >> iwl_ . Beautify iwl_setup_rx_handlers and do some other minor coding
> >> style changes.
> >>
> >> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> >> ---
> > this patch break the compiling
> >
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778:17: error: undefined
> > identifier 'TASK_INTERRUPTIBLE'
> > CC [M] drivers/net/wireless/iwlwifi/iwl-rx.o
> > drivers/net/wireless/iwlwifi/iwl-rx.c: In function
> > ‘iwl_rx_card_state_notif’:
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: ‘TASK_INTERRUPTIBLE’
> > undeclared (first use in this function)
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: (Each undeclared
> > identifier is reported only once
> > drivers/net/wireless/iwlwifi/iwl-rx.c:778: error: for each function it
> > appears in.)
> > make[1]: *** [drivers/net/wireless/iwlwifi/iwl-rx.o] Error 1
> > make: *** [_module_drivers/net/wireless/iwlwifi] Error 2
> >
> >
> > Thanks
> > Wey
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
next prev parent reply other threads:[~2011-03-07 8:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 16:51 [PATCH 1/3] iwlwifi: move rx handlers code to iwl-rx.c Stanislaw Gruszka
2011-03-04 16:51 ` [PATCH 2/3] iwlwifi: cleanup iwl_good_plcp_health Stanislaw Gruszka
2011-03-04 16:47 ` Guy, Wey-Yi
2011-03-04 16:51 ` [PATCH 3/3] iwlwifi: avoid too frequent recover from statistics Stanislaw Gruszka
2011-03-04 16:46 ` Guy, Wey-Yi
2011-03-04 16:52 ` [PATCH 1/3] iwlwifi: move rx handlers code to iwl-rx.c Guy, Wey-Yi
2011-03-06 21:34 ` Guy, Wey-Yi
2011-03-06 23:47 ` Daniel Halperin
2011-03-07 8:12 ` Stanislaw Gruszka [this message]
2011-03-07 9:20 ` Undefined TASK_INTERRUPTIBLE (Was: Re: [PATCH 1/3] iwlwifi: move rx handlers code to iwl-rx.c) Peter Zijlstra
2011-03-07 13:12 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110307081241.GA2216@redhat.com \
--to=sgruszka@redhat.com \
--cc=dhalperi@cs.washington.edu \
--cc=ilw@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.