[PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads.

[PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads.

[Manoj Iyer]

Please consider the following patch that adds support for auto loading 
thinkpad_acpi module on newer Lenovo ThinkPads that have HKEY HID set 
to LEN0068 instead of IBM0068. 

==== dsdt.dsl =============================================
                    Device (HKEY)
                    {
                        Name (_HID, EisaId ("LEN0068"))
                        Method (_STA, 0, NotSerialized)
                        {
                            Return (0x0F)
                        }
============================================================

This patch was tested on a Lenovo x120e. 

Thank you
Manoj Iyer

[PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads.

[Manoj Iyer]

The newer Lenovo ThinkPads have HKEY HID of LEN0068 instead
of IBM0068. Added new HID so that thinkpad_acpi module will
auto load on these newer Lenovo ThinkPads.

Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
---
 drivers/platform/x86/thinkpad_acpi.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index eb99223..125d891 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -128,7 +128,8 @@ enum {
 };
 
 /* ACPI HIDs */
-#define TPACPI_ACPI_HKEY_HID		"IBM0068"
+#define TPACPI_ACPI_IBM_HKEY_HID	"IBM0068"
+#define TPACPI_ACPI_LENOVO_HKEY_HID	"LEN0068"
 #define TPACPI_ACPI_EC_HID		"PNP0C09"
 
 /* Input IDs */
@@ -3879,7 +3880,8 @@ errexit:
 }
 
 static const struct acpi_device_id ibm_htk_device_ids[] = {
-	{TPACPI_ACPI_HKEY_HID, 0},
+	{TPACPI_ACPI_IBM_HKEY_HID, 0},
+	{TPACPI_ACPI_LENOVO_HKEY_HID, 0},
 	{"", 0},
 };
 
-- 
1.7.1

Re: [PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads.

[Henrique de Moraes Holschuh]

On Mon, 07 Mar 2011, Manoj Iyer wrote:
> Please consider the following patch that adds support for auto loading 
> thinkpad_acpi module on newer Lenovo ThinkPads that have HKEY HID set 
> to LEN0068 instead of IBM0068. 

Does the driver do anything useful on these Lenovo thinkpads?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads.

[Manoj Iyer]

Absolutely, it enables hotkeys on a host of new Lenovo thinkpads,
x120e, T420, T520 etc.

-----------------------------------------------------
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement Team
------------------------------------------------------



On Mon, Mar 7, 2011 at 6:43 PM, Henrique de Moraes Holschuh
<hmh@hmh.eng.br> wrote:
> On Mon, 07 Mar 2011, Manoj Iyer wrote:
>> Please consider the following patch that adds support for auto loading
>> thinkpad_acpi module on newer Lenovo ThinkPads that have HKEY HID set
>> to LEN0068 instead of IBM0068.
>
> Does the driver do anything useful on these Lenovo thinkpads?
>
> --
>  "One disk to rule them all, One disk to find them. One disk to bring
>  them all and in the darkness grind them. In the Land of Redmond
>  where the shadows lie." -- The Silicon Valley Tarot
>  Henrique Holschuh
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: [PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads.

[Henrique de Moraes Holschuh]

On Mon, 07 Mar 2011, Manoj Iyer wrote:
> The newer Lenovo ThinkPads have HKEY HID of LEN0068 instead
> of IBM0068. Added new HID so that thinkpad_acpi module will
> auto load on these newer Lenovo ThinkPads.
> 
> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>

Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index eb99223..125d891 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -128,7 +128,8 @@ enum {
>  };
>  
>  /* ACPI HIDs */
> -#define TPACPI_ACPI_HKEY_HID		"IBM0068"
> +#define TPACPI_ACPI_IBM_HKEY_HID	"IBM0068"
> +#define TPACPI_ACPI_LENOVO_HKEY_HID	"LEN0068"
>  #define TPACPI_ACPI_EC_HID		"PNP0C09"
>  
>  /* Input IDs */
> @@ -3879,7 +3880,8 @@ errexit:
>  }
>  
>  static const struct acpi_device_id ibm_htk_device_ids[] = {
> -	{TPACPI_ACPI_HKEY_HID, 0},
> +	{TPACPI_ACPI_IBM_HKEY_HID, 0},
> +	{TPACPI_ACPI_LENOVO_HKEY_HID, 0},
>  	{"", 0},
>  };

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads.

[Manoj Iyer]

Henrique,

Thanks the ack on the patch, any idea when this will be Q'ed for linus tree ?

-----------------------------------------------------
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement Team
------------------------------------------------------



On Tue, Mar 8, 2011 at 6:35 AM, Henrique de Moraes Holschuh
<hmh@hmh.eng.br> wrote:
> On Mon, 07 Mar 2011, Manoj Iyer wrote:
>> The newer Lenovo ThinkPads have HKEY HID of LEN0068 instead
>> of IBM0068. Added new HID so that thinkpad_acpi module will
>> auto load on these newer Lenovo ThinkPads.
>>
>> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
>
> Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
>
>> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
>> index eb99223..125d891 100644
>> --- a/drivers/platform/x86/thinkpad_acpi.c
>> +++ b/drivers/platform/x86/thinkpad_acpi.c
>> @@ -128,7 +128,8 @@ enum {
>>  };
>>
>>  /* ACPI HIDs */
>> -#define TPACPI_ACPI_HKEY_HID         "IBM0068"
>> +#define TPACPI_ACPI_IBM_HKEY_HID     "IBM0068"
>> +#define TPACPI_ACPI_LENOVO_HKEY_HID  "LEN0068"
>>  #define TPACPI_ACPI_EC_HID           "PNP0C09"
>>
>>  /* Input IDs */
>> @@ -3879,7 +3880,8 @@ errexit:
>>  }
>>
>>  static const struct acpi_device_id ibm_htk_device_ids[] = {
>> -     {TPACPI_ACPI_HKEY_HID, 0},
>> +     {TPACPI_ACPI_IBM_HKEY_HID, 0},
>> +     {TPACPI_ACPI_LENOVO_HKEY_HID, 0},
>>       {"", 0},
>>  };
>
> --
>  "One disk to rule them all, One disk to find them. One disk to bring
>  them all and in the darkness grind them. In the Land of Redmond
>  where the shadows lie." -- The Silicon Valley Tarot
>  Henrique Holschuh
>

[PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads.

[Andy Lutomirski]

From: Andrew Lutomirski <luto@mit.edu>

From: Manoj Iyer <manoj.iyer@canonical.com>
Date: Mon, 7 Mar 2011 17:26:47 -0600

The newer Lenovo ThinkPads have HKEY HID of LEN0068 instead
of IBM0068. Added new HID so that thinkpad_acpi module will
auto load on these newer Lenovo ThinkPads.

Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: stable@kernel.org
Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
Signed-off-by: Andy Lutomirski <luto@mit.edu>
---

Hi, mjg-

Can you add this to your tree for 2.6.39 (or 2.6.40 if you think it's
too late for a missing device ID)?  This is needed on a bunch of new
ThinkPad laptops (including mine).  Henrique asked me to forward my patch
or this one, and I think this one is slightly prettier.

hmh's email:

http://www.mail-archive.com/platform-driver-x86@vger.kernel.org/msg01817.html

original patch from Manoj Iyer:

https://lkml.org/lkml/2011/3/8/125

 drivers/platform/x86/thinkpad_acpi.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index eb99223..125d891 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -128,7 +128,8 @@ enum {
 };
 
 /* ACPI HIDs */
-#define TPACPI_ACPI_HKEY_HID		"IBM0068"
+#define TPACPI_ACPI_IBM_HKEY_HID	"IBM0068"
+#define TPACPI_ACPI_LENOVO_HKEY_HID	"LEN0068"
 #define TPACPI_ACPI_EC_HID		"PNP0C09"
 
 /* Input IDs */
@@ -3879,7 +3880,8 @@ errexit:
 }
 
 static const struct acpi_device_id ibm_htk_device_ids[] = {
-	{TPACPI_ACPI_HKEY_HID, 0},
+	{TPACPI_ACPI_IBM_HKEY_HID, 0},
+	{TPACPI_ACPI_LENOVO_HKEY_HID, 0},
 	{"", 0},
 };
 
-- 
1.7.5.1