[PATCHv3 3/4] sanity.bbclass: Check for /proc/sys/vm/mmap_min_addr to be >= 65536

[PATCHv3 3/4] sanity.bbclass: Check for /proc/sys/vm/mmap_min_addr to be >= 65536

[Khem Raj]

* Now qemu can handle lower values we can chnage this sanity test
  to check of values if less than 65536

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/classes/sanity.bbclass |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 13940f8..aae5028 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -170,10 +170,12 @@ def check_sanity(e):
         # This path is no longer user-readable in modern (very recent) Linux
         try:
             if os.path.exists("/proc/sys/vm/mmap_min_addr"):
-                f = file("/proc/sys/vm/mmap_min_addr", "r")
-                if (f.read().strip() != "0"):
-                        messages = messages + "/proc/sys/vm/mmap_min_addr is not 0. This will cause problems with qemu so please fix the value (as root).\n\nTo fix this in later reboots, set vm.mmap_min_addr = 0 in /etc/sysctl.conf.\n"
-                f.close()
+                f = open("/proc/sys/vm/mmap_min_addr", "r")
+                try:
+                    if (int(f.read().strip()) < 65536):
+                        messages = messages + "/proc/sys/vm/mmap_min_addr is not >= 65536. This will cause problems with qemu so please fix the value (as root).\n\nTo fix this in later reboots, set vm.mmap_min_addr = 65536 in /etc/sysctl.conf.\n"
+                finally:
+                    f.close()
         except:
             pass
 
-- 
1.7.4.1

Re: [PATCHv3 3/4] sanity.bbclass: Check for /proc/sys/vm/mmap_min_addr to be >= 65536

[Richard Purdie]

On Mon, 2011-03-07 at 22:46 -0800, Khem Raj wrote:
> * Now qemu can handle lower values we can chnage this sanity test
>   to check of values if less than 65536
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/classes/sanity.bbclass |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)

Merged into master, thanks.

Richard