[PATCH] transmission: add recipe for 2.22 version

[PATCH] transmission: add recipe for 2.22 version

[Lukas-David Gorris]

Depends on the the previously sent libevent bump.

From: Lukas-David Gorris <lukas.gorris@gmail.com>
Date: Fri, 11 Mar 2011 02:00:56 +0100
Subject: [oe] [PATCH] transmission: add recipe for 2.22 version

---
 recipes/transmission/transmission_2.22.bb |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
 create mode 100644 recipes/transmission/transmission_2.22.bb

diff --git a/recipes/transmission/transmission_2.22.bb
b/recipes/transmission/transmission_2.22.bb
new file mode 100644
index 0000000..e9a7891
--- /dev/null
+++ b/recipes/transmission/transmission_2.22.bb
@@ -0,0 +1,9 @@
+require transmission.inc
+
+DEPENDS += "libevent"
+
+PR = ${INC_PR}.1
+
+SRC_URI[archive.md5sum] = "6499986bf769276310b00bda1090090d"
+SRC_URI[archive.sha256sum] =
"5a4079194f45260c143f21ea6f33ce2660d89fca02ad8f1e65169968d365e4d4"
+
-- 
1.7.1

Re: [PATCH] transmission: add recipe for 2.22 version

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]

Dear Lukas-David,


Am Freitag, den 11.03.2011, 02:03 +0100 schrieb Lukas-David Gorris:
> Depends on the the previously sent libevent bump.

Using `git format-patch -2 -s` you can create patches where the
dependencies are shown in the subject, e. g. [PATCH 1/2] and [PATCH
2/2].

> From: Lukas-David Gorris <lukas.gorris@gmail.com>
> Date: Fri, 11 Mar 2011 02:00:56 +0100
> Subject: [oe] [PATCH] transmission: add recipe for 2.22 version

As already written in another thread, your MUA mangled the patches.
Please turn off automatic line wrapping (normal to preformatted) or
using `git send-email`.

Your Signed-off-by line is also missing as demanded by the commit policy
[1].

Secondly, I would appreciate if you could add to the commit message,
what build configuration you tested your new recipe/patch with and if
all operations worked when running it.

> ---
>  recipes/transmission/transmission_2.22.bb |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/transmission/transmission_2.22.bb
> 
> diff --git a/recipes/transmission/transmission_2.22.bb
> b/recipes/transmission/transmission_2.22.bb
> new file mode 100644
> index 0000000..e9a7891
> --- /dev/null
> +++ b/recipes/transmission/transmission_2.22.bb
> @@ -0,0 +1,9 @@
> +require transmission.inc
> +
> +DEPENDS += "libevent"
> +
> +PR = ${INC_PR}.1

You should start at 0.

> +SRC_URI[archive.md5sum] = "6499986bf769276310b00bda1090090d"
> +SRC_URI[archive.sha256sum] = "5a4079194f45260c143f21ea6f33ce2660d89fca02ad8f1e65169968d365e4d4"


Thanks,

Paul


[1] http://openembedded.org/index.php/Commit_Policy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] transmission: add recipe for 2.22 version

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 2081 bytes --]

Dear Graeme,


Am Freitag, den 11.03.2011, 11:00 +0100 schrieb Paul Menzel:

> Am Freitag, den 11.03.2011, 02:03 +0100 schrieb Lukas-David Gorris:
> > Depends on the the previously sent libevent bump.
> 
> Using `git format-patch -2 -s` you can create patches where the
> dependencies are shown in the subject, e. g. [PATCH 1/2] and [PATCH
> 2/2].
> 
> > From: Lukas-David Gorris <lukas.gorris@gmail.com>
> > Date: Fri, 11 Mar 2011 02:00:56 +0100
> > Subject: [oe] [PATCH] transmission: add recipe for 2.22 version
> 
> As already written in another thread, your MUA mangled the patches.
> Please turn off automatic line wrapping (normal to preformatted) or
> using `git send-email`.
> 
> Your Signed-off-by line is also missing as demanded by the commit policy
> [1].
> 
> Secondly, I would appreciate if you could add to the commit message,
> what build configuration you tested your new recipe/patch with and if
> all operations worked when running it.
> 
> > ---
> >  recipes/transmission/transmission_2.22.bb |    9 +++++++++
> >  1 files changed, 9 insertions(+), 0 deletions(-)
> >  create mode 100644 recipes/transmission/transmission_2.22.bb
> > 
> > diff --git a/recipes/transmission/transmission_2.22.bb
> > b/recipes/transmission/transmission_2.22.bb
> > new file mode 100644
> > index 0000000..e9a7891
> > --- /dev/null
> > +++ b/recipes/transmission/transmission_2.22.bb
> > @@ -0,0 +1,9 @@
> > +require transmission.inc
> > +
> > +DEPENDS += "libevent"
> > +
> > +PR = ${INC_PR}.1
> 
> You should start at 0.
> 
> > +SRC_URI[archive.md5sum] = "6499986bf769276310b00bda1090090d"
> > +SRC_URI[archive.sha256sum] = "5a4079194f45260c143f21ea6f33ce2660d89fca02ad8f1e65169968d365e4d4"

why did you commit in e124c44f [1] without my remarks being addressed?
Also the things you put into the commit message could have been left
out.


Thanks,

Paul


> [1] http://openembedded.org/index.php/Commit_Policy
[2] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=e124c44f14b887aec64c71d33120508cb033af6e

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] transmission: add recipe for 2.22 version

[Graeme Gregory]

On 11/03/2011 14:54, Paul Menzel wrote:
> Dear Graeme,
>
>
> Am Freitag, den 11.03.2011, 11:00 +0100 schrieb Paul Menzel:
>
>> Am Freitag, den 11.03.2011, 02:03 +0100 schrieb Lukas-David Gorris:
>>> Depends on the the previously sent libevent bump.
>> Using `git format-patch -2 -s` you can create patches where the
>> dependencies are shown in the subject, e. g. [PATCH 1/2] and [PATCH
>> 2/2].
>>
>>> From: Lukas-David Gorris <lukas.gorris@gmail.com>
>>> Date: Fri, 11 Mar 2011 02:00:56 +0100
>>> Subject: [oe] [PATCH] transmission: add recipe for 2.22 version
>> As already written in another thread, your MUA mangled the patches.
>> Please turn off automatic line wrapping (normal to preformatted) or
>> using `git send-email`.
>>
>> Your Signed-off-by line is also missing as demanded by the commit policy
>> [1].
>>
>> Secondly, I would appreciate if you could add to the commit message,
>> what build configuration you tested your new recipe/patch with and if
>> all operations worked when running it.
>>
>>> ---
>>>  recipes/transmission/transmission_2.22.bb |    9 +++++++++
>>>  1 files changed, 9 insertions(+), 0 deletions(-)
>>>  create mode 100644 recipes/transmission/transmission_2.22.bb
>>>
>>> diff --git a/recipes/transmission/transmission_2.22.bb
>>> b/recipes/transmission/transmission_2.22.bb
>>> new file mode 100644
>>> index 0000000..e9a7891
>>> --- /dev/null
>>> +++ b/recipes/transmission/transmission_2.22.bb
>>> @@ -0,0 +1,9 @@
>>> +require transmission.inc
>>> +
>>> +DEPENDS += "libevent"
>>> +
>>> +PR = ${INC_PR}.1
>> You should start at 0.
>>
>>> +SRC_URI[archive.md5sum] = "6499986bf769276310b00bda1090090d"
>>> +SRC_URI[archive.sha256sum] = "5a4079194f45260c143f21ea6f33ce2660d89fca02ad8f1e65169968d365e4d4"
> why did you commit in e124c44f [1] without my remarks being addressed?
> Also the things you put into the commit message could have been left
> out.
>
>
I got your comments long after I had already done the commits. Im
getting a lot of OE emails seriously delayed today.

I used pw-am as per the process recomended.

Graeme

[PATCH] transmission: add recipe for 2.22 version

[Lukas-David Gorris]

Depends on the the previously sent libevent bump.

From: Lukas-David Gorris <lukas.gorris@gmail.com>
Date: Fri, 11 Mar 2011 02:00:56 +0100
Subject: [oe] [PATCH] transmission: add recipe for 2.22 version

---
 recipes/transmission/transmission_2.22.bb |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
 create mode 100644 recipes/transmission/transmission_2.22.bb

diff --git a/recipes/transmission/transmission_2.22.bb
b/recipes/transmission/transmission_2.22.bb
new file mode 100644
index 0000000..e9a7891
--- /dev/null
+++ b/recipes/transmission/transmission_2.22.bb
@@ -0,0 +1,9 @@
+require transmission.inc
+
+DEPENDS += "libevent"
+
+PR = ${INC_PR}.1
+
+SRC_URI[archive.md5sum] = "6499986bf769276310b00bda1090090d"
+SRC_URI[archive.sha256sum] =
"5a4079194f45260c143f21ea6f33ce2660d89fca02ad8f1e65169968d365e4d4"
+
-- 
1.7.1

Re: [PATCH] transmission: add recipe for 2.22 version

[Lukas-David Gorris]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

> Depends on the the previously sent libevent bump.
> 
> From: Lukas-David Gorris <lukas.gorris@gmail.com>
> Date: Fri, 11 Mar 2011 02:00:56 +0100
> Subject: [oe] [PATCH] transmission: add recipe for 2.22 version

Sorry for the corrupted patch. Resent in attachment.

Best,
Lukas


[-- Attachment #2: transmission-bump.diff --]
[-- Type: text/x-patch, Size: 822 bytes --]

From: Lukas-David Gorris <lukas.gorris@gmail.com>
Date: Fri, 11 Mar 2011 02:00:56 +0100
Subject: [oe][PATCH] transmission: add recipe for 2.22 version

---
 recipes/transmission/transmission_2.22.bb |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
 create mode 100644 recipes/transmission/transmission_2.22.bb

diff --git a/recipes/transmission/transmission_2.22.bb b/recipes/transmission/transmission_2.22.bb
new file mode 100644
index 0000000..e9a7891
--- /dev/null
+++ b/recipes/transmission/transmission_2.22.bb
@@ -0,0 +1,9 @@
+require transmission.inc
+
+DEPENDS += "libevent"
+
+PR = ${INC_PR}.1
+
+SRC_URI[archive.md5sum] = "6499986bf769276310b00bda1090090d"
+SRC_URI[archive.sha256sum] = "5a4079194f45260c143f21ea6f33ce2660d89fca02ad8f1e65169968d365e4d4"
+
-- 
1.7.1

Re: [PATCH] transmission: add recipe for 2.22 version

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

Am Freitag, den 11.03.2011, 11:08 +0100 schrieb Lukas-David Gorris:
> > Depends on the the previously sent libevent bump.
> > 
> > From: Lukas-David Gorris <lukas.gorris@gmail.com>
> > Date: Fri, 11 Mar 2011 02:00:56 +0100
> > Subject: [oe] [PATCH] transmission: add recipe for 2.22 version
> 
> Sorry for the corrupted patch. Resent in attachment.

I am sorry. My comments in my previous answer [1] still apply.

Please resend as »[PATCH v2]«.


Thanks,

Paul


[1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-March/030793.html

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]