Re: [PATCH v2 1/8] drm/rockchip: vop2: Switch impossible format conditional to WARN_ON

From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: "Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Thomas Zimmermann" <tzimmermann@suse.de>
Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Daniel Stone <daniels@collabora.com>
Subject: Re: [PATCH v2 1/8] drm/rockchip: vop2: Switch impossible format conditional to WARN_ON
Date: Tue, 20 Jan 2026 13:57:56 +0100	[thread overview]
Message-ID: <13000903.O9o76ZdvQC@workhorse> (raw)
In-Reply-To: <c11ef222-c661-4937-8f35-25f450ab71bc@suse.de>

On Tuesday, 20 January 2026 13:49:12 Central European Standard Time Thomas Zimmermann wrote:
> Hi
> 
> Am 06.12.25 um 21:45 schrieb Nicolas Frattaroli:
> > From: Daniel Stone <daniels@collabora.com>
> >
> > We should never be able to create a framebuffer with an unsupported
> > format, so throw a warning if this ever happens, instead of attempting
> > to stagger on.
> >
> > Signed-off-by: Daniel Stone <daniels@collabora.com>
> > Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> > ---
> >   drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> > index 498df0ce4680..20b49209ddcd 100644
> > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> > @@ -1030,7 +1030,8 @@ static int vop2_plane_atomic_check(struct drm_plane *plane,
> >   		return 0;
> >   
> >   	format = vop2_convert_format(fb->format->format);
> > -	if (format < 0)
> > +	/* We shouldn't be able to create a fb for an unsupported format */
> > +	if (WARN_ON(format < 0))
> 
> Please use drm_WARN_ON() here.

Hi Thomas,

A later revision of this series has already been applied. Feel free
to send such a patch however.

Kind regards,
Nicolas Frattaroli

> 
> Best regards
> Thomas
> 
> >   		return format;
> >   
> >   	/* Co-ordinates have now been clipped */
> >
> 
> 