From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch 2/2] iwlwifi: remove duplicate initialization in
Date: Tue, 15 Mar 2011 09:05:14 +0000 [thread overview]
Message-ID: <1300179914.5082.214.camel@wwguy-huron> (raw)
In-Reply-To: <20110315070324.GR2008@bicker>
On Tue, 2011-03-15 at 00:03 -0700, Dan Carpenter wrote:
> We initialize exit_pending twice. It's the second initialization which
> is correct. That was added in d745d472af "iwlwifi: cancel scan when
> down the device".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
Acked-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
> index 321b18b..7adc60e 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-agn.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
> @@ -2537,7 +2537,7 @@ static void iwl_cancel_deferred_work(struct iwl_priv *priv);
> static void __iwl_down(struct iwl_priv *priv)
> {
> unsigned long flags;
> - int exit_pending = test_bit(STATUS_EXIT_PENDING, &priv->status);
> + int exit_pending;
>
> IWL_DEBUG_INFO(priv, DRV_NAME " is going down\n");
>
WARNING: multiple messages have this Message-ID (diff)
From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch 2/2] iwlwifi: remove duplicate initialization in __iwl_down()
Date: Tue, 15 Mar 2011 02:05:14 -0700 [thread overview]
Message-ID: <1300179914.5082.214.camel@wwguy-huron> (raw)
In-Reply-To: <20110315070324.GR2008@bicker>
On Tue, 2011-03-15 at 00:03 -0700, Dan Carpenter wrote:
> We initialize exit_pending twice. It's the second initialization which
> is correct. That was added in d745d472af "iwlwifi: cancel scan when
> down the device".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
Acked-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
> index 321b18b..7adc60e 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-agn.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
> @@ -2537,7 +2537,7 @@ static void iwl_cancel_deferred_work(struct iwl_priv *priv);
> static void __iwl_down(struct iwl_priv *priv)
> {
> unsigned long flags;
> - int exit_pending = test_bit(STATUS_EXIT_PENDING, &priv->status);
> + int exit_pending;
>
> IWL_DEBUG_INFO(priv, DRV_NAME " is going down\n");
>
next prev parent reply other threads:[~2011-03-15 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 7:03 [patch 2/2] iwlwifi: remove duplicate initialization in Dan Carpenter
2011-03-15 7:03 ` [patch 2/2] iwlwifi: remove duplicate initialization in __iwl_down() Dan Carpenter
2011-03-15 9:05 ` Guy, Wey-Yi [this message]
2011-03-15 9:05 ` Guy, Wey-Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300179914.5082.214.camel@wwguy-huron \
--to=wey-yi.w.guy@intel.com \
--cc=error27@gmail.com \
--cc=ilw@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.