From: Matt Mackall <mpm@selenic.com>
To: George Spelvin <linux@horizon.com>
Cc: penberg@cs.helsinki.fi, herbert@gondor.hengli.com.au,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] drivers/char/random: Split out __get_random_int
Date: Tue, 15 Mar 2011 22:03:56 -0500 [thread overview]
Message-ID: <1300244636.3128.426.camel@calx> (raw)
In-Reply-To: <20110316022804.27682.qmail@science.horizon.com>
On Sun, 2011-03-13 at 20:57 -0400, George Spelvin wrote:
> The unlocked function is needed for following work.
> No API change.
As I mentioned last time this code was discussed, we're already one
crypto-savvy attacker away from this code becoming a security hole.
We really need to give it a serious rethink before we make it look
anything like a general-use API.
And you've got it backwards here: __ should be the unlocked, dangerous
version. But the locked version already has a __ because it's already
dangerous.
--
Mathematics is the supreme nostalgia of our time.
WARNING: multiple messages have this Message-ID (diff)
From: Matt Mackall <mpm@selenic.com>
To: George Spelvin <linux@horizon.com>
Cc: penberg@cs.helsinki.fi, herbert@gondor.apana.org.au,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] drivers/char/random: Split out __get_random_int
Date: Tue, 15 Mar 2011 22:03:56 -0500 [thread overview]
Message-ID: <1300244636.3128.426.camel@calx> (raw)
In-Reply-To: <20110316022804.27682.qmail@science.horizon.com>
On Sun, 2011-03-13 at 20:57 -0400, George Spelvin wrote:
> The unlocked function is needed for following work.
> No API change.
As I mentioned last time this code was discussed, we're already one
crypto-savvy attacker away from this code becoming a security hole.
We really need to give it a serious rethink before we make it look
anything like a general-use API.
And you've got it backwards here: __ should be the unlocked, dangerous
version. But the locked version already has a __ because it's already
dangerous.
--
Mathematics is the supreme nostalgia of our time.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-16 3:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 0:57 [PATCH 2/8] drivers/char/random: Split out __get_random_int George Spelvin
2011-03-14 0:57 ` George Spelvin
2011-03-16 3:03 ` Matt Mackall [this message]
2011-03-16 3:03 ` Matt Mackall
2011-03-16 4:24 ` George Spelvin
2011-03-16 4:24 ` George Spelvin
2011-03-16 6:27 ` Pekka Enberg
2011-03-16 6:27 ` Pekka Enberg
2011-03-16 14:24 ` Matt Mackall
2011-03-16 14:24 ` Matt Mackall
2011-03-16 18:35 ` George Spelvin
2011-03-16 18:35 ` George Spelvin
2011-03-16 20:35 ` Matt Mackall
2011-03-16 20:35 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300244636.3128.426.camel@calx \
--to=mpm@selenic.com \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@horizon.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.