From: Artem Bityutskiy <dedekind1@gmail.com>
To: Murali Nalajala <mnalajal@codeaurora.org>
Cc: dwmw2@infradead.org, linux-arm-msm@vger.kernel.org,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Dima Zavin <dima@android.com>
Subject: Re: [PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.
Date: Mon, 21 Mar 2011 09:12:31 +0200 [thread overview]
Message-ID: <1300691551.2761.8.camel@localhost> (raw)
In-Reply-To: <4D86F295.8040409@codeaurora.org>
On Mon, 2011-03-21 at 12:09 +0530, Murali Nalajala wrote:
> On 3/8/2011 11:11 PM, Murali Nalajala wrote:
> > On 3/8/2011 12:50 AM, Artem Bityutskiy wrote:
> >> On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
> >>> Lets non-standard NAND drivers take advantage of known NAND
> >>> chip information.
> >>>
> >>> The initial development of msm nand driver, driver uses the supported
> >>> NAND devices information as a hardcoded table. Remove the existing
> >>> hardcoded supported flash device table and read the flash device
> >>> information from the flash id table which are part of the mtd subsystem.
> >>
> >> Why this initial version should be upstream? Why wouldn't you make it
> >> "standard" first?
> >>
> >
> > Currently we are not fully using the MTD nand subsystem. That's the
> > intention author has introduced "non-standard" here!!!
> >
> > Thanks,
> > Murali N
> >
>
> Any reviews comments on this change?
No, I think you should "sell" your driver better than that. Indeed,
Q: "Why this initial version should be upstream? Why wouldn't you make
it "standard" first?"
A: Currently we are not fully using the MTD nand subsystem. That's the
intention author has introduced "non-standard" here!!!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Murali Nalajala <mnalajal@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, dwmw2@infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, Dima Zavin <dima@android.com>
Subject: Re: [PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.
Date: Mon, 21 Mar 2011 09:12:31 +0200 [thread overview]
Message-ID: <1300691551.2761.8.camel@localhost> (raw)
In-Reply-To: <4D86F295.8040409@codeaurora.org>
On Mon, 2011-03-21 at 12:09 +0530, Murali Nalajala wrote:
> On 3/8/2011 11:11 PM, Murali Nalajala wrote:
> > On 3/8/2011 12:50 AM, Artem Bityutskiy wrote:
> >> On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
> >>> Lets non-standard NAND drivers take advantage of known NAND
> >>> chip information.
> >>>
> >>> The initial development of msm nand driver, driver uses the supported
> >>> NAND devices information as a hardcoded table. Remove the existing
> >>> hardcoded supported flash device table and read the flash device
> >>> information from the flash id table which are part of the mtd subsystem.
> >>
> >> Why this initial version should be upstream? Why wouldn't you make it
> >> "standard" first?
> >>
> >
> > Currently we are not fully using the MTD nand subsystem. That's the
> > intention author has introduced "non-standard" here!!!
> >
> > Thanks,
> > Murali N
> >
>
> Any reviews comments on this change?
No, I think you should "sell" your driver better than that. Indeed,
Q: "Why this initial version should be upstream? Why wouldn't you make
it "standard" first?"
A: Currently we are not fully using the MTD nand subsystem. That's the
intention author has introduced "non-standard" here!!!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.
Date: Mon, 21 Mar 2011 09:12:31 +0200 [thread overview]
Message-ID: <1300691551.2761.8.camel@localhost> (raw)
In-Reply-To: <4D86F295.8040409@codeaurora.org>
On Mon, 2011-03-21 at 12:09 +0530, Murali Nalajala wrote:
> On 3/8/2011 11:11 PM, Murali Nalajala wrote:
> > On 3/8/2011 12:50 AM, Artem Bityutskiy wrote:
> >> On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
> >>> Lets non-standard NAND drivers take advantage of known NAND
> >>> chip information.
> >>>
> >>> The initial development of msm nand driver, driver uses the supported
> >>> NAND devices information as a hardcoded table. Remove the existing
> >>> hardcoded supported flash device table and read the flash device
> >>> information from the flash id table which are part of the mtd subsystem.
> >>
> >> Why this initial version should be upstream? Why wouldn't you make it
> >> "standard" first?
> >>
> >
> > Currently we are not fully using the MTD nand subsystem. That's the
> > intention author has introduced "non-standard" here!!!
> >
> > Thanks,
> > Murali N
> >
>
> Any reviews comments on this change?
No, I think you should "sell" your driver better than that. Indeed,
Q: "Why this initial version should be upstream? Why wouldn't you make
it "standard" first?"
A: Currently we are not fully using the MTD nand subsystem. That's the
intention author has introduced "non-standard" here!!!
--
Best Regards,
Artem Bityutskiy (????? ????????)
next prev parent reply other threads:[~2011-03-21 7:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 0:08 [PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone Murali Nalajala
2011-03-08 0:08 ` Murali Nalajala
2011-03-08 0:08 ` Murali Nalajala
2011-03-08 7:50 ` Artem Bityutskiy
2011-03-08 7:50 ` Artem Bityutskiy
2011-03-08 7:50 ` Artem Bityutskiy
2011-03-08 17:41 ` Murali Nalajala
2011-03-08 17:41 ` Murali Nalajala
2011-03-08 17:41 ` Murali Nalajala
2011-03-21 6:39 ` Murali Nalajala
2011-03-21 6:39 ` Murali Nalajala
2011-03-21 6:39 ` Murali Nalajala
2011-03-21 7:12 ` Artem Bityutskiy [this message]
2011-03-21 7:12 ` Artem Bityutskiy
2011-03-21 7:12 ` Artem Bityutskiy
2011-03-21 7:58 ` Murali Nalajala
2011-03-21 7:58 ` Murali Nalajala
2011-03-21 7:58 ` Murali Nalajala
2011-03-22 6:41 ` Murali Nalajala
2011-03-22 6:41 ` Murali Nalajala
2011-03-22 6:41 ` Murali Nalajala
2011-03-22 8:11 ` Artem Bityutskiy
2011-03-22 8:11 ` Artem Bityutskiy
2011-03-22 8:11 ` Artem Bityutskiy
2011-04-06 4:38 ` Murali Nalajala
2011-04-06 4:38 ` Murali Nalajala
2011-04-06 4:38 ` Murali Nalajala
2011-04-06 7:21 ` Artem Bityutskiy
2011-04-06 7:21 ` Artem Bityutskiy
2011-04-06 7:21 ` Artem Bityutskiy
2011-04-07 6:28 ` Dima Zavin
2011-04-07 6:28 ` Dima Zavin
2011-04-07 6:28 ` Dima Zavin
2011-04-14 23:33 ` David Brown
2011-04-14 23:33 ` David Brown
2011-04-14 23:33 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300691551.2761.8.camel@localhost \
--to=dedekind1@gmail.com \
--cc=dima@android.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mnalajal@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.