From: Ben Hutchings <bhutchings@solarflare.com>
To: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Cc: davem@davemloft.net, netdev@vger.kernel.org, eugenia@mellanox.co.il
Subject: Re: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i
Date: Wed, 23 Mar 2011 14:04:14 +0000 [thread overview]
Message-ID: <1300889054.26693.527.camel@localhost> (raw)
In-Reply-To: <4D89B16F.4040008@mellanox.co.il>
On Wed, 2011-03-23 at 10:38 +0200, Yevgeny Petrilin wrote:
> HW revision is derived from device ID and rev id.
[...]
> - sprintf(drvinfo->driver, DRV_NAME " (%s)", mdev->dev->board_id);
> + switch (mdev->dev->rev_id) {
> + case 0xa0:
> + if (dev->dev_id >= MLX4_EN_CX3_LOW_ID && dev->dev_id <= MLX4_EN_CX3_HIGH_ID)
> + sprintf(drvinfo->driver, DRV_NAME " (%s_CX-3)", mdev->dev->board_id);
> + else
> + sprintf(drvinfo->driver, DRV_NAME " (%s_CX)", mdev->dev->board_id);
> + break;
> + case 0xb0:
> + sprintf(drvinfo->driver, DRV_NAME " (%s_CX-2)", mdev->dev->board_id);
> + break;
> + default:
> + sprintf(drvinfo->driver, DRV_NAME " (%s)", mdev->dev->board_id);
> + break;
[...]
This is an abuse of the ethtool_drvinfo::driver field.
Your users can use lspci -v, can't they?
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-03-23 14:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 8:38 [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i Yevgeny Petrilin
2011-03-23 14:04 ` Ben Hutchings [this message]
2011-03-23 15:10 ` Yevgeny Petrilin
2011-03-23 15:46 ` Ben Hutchings
2011-03-23 15:54 ` Yevgeny Petrilin
2011-03-23 16:08 ` Ben Hutchings
2011-03-23 17:06 ` Stephen Hemminger
2011-03-23 15:58 ` Stephen Hemminger
2011-03-23 19:36 ` David Miller
2011-03-24 3:40 ` Ben Hutchings
2011-03-24 6:26 ` Yevgeny Petrilin
2011-03-23 19:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300889054.26693.527.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eugenia@mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.