From: Stephen Hemminger <shemminger@vyatta.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Yevgeny Petrilin <yevgenyp@mellanox.co.il>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Eugenia Emantayev <eugenia@mellanox.co.il>
Subject: Re: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i
Date: Wed, 23 Mar 2011 08:58:15 -0700 [thread overview]
Message-ID: <20110323085815.0a2cbcb0@nehalam> (raw)
In-Reply-To: <1300895205.2638.0.camel@bwh-desktop>
On Wed, 23 Mar 2011 15:46:45 +0000
Ben Hutchings <bhutchings@solarflare.com> wrote:
> On Wed, 2011-03-23 at 15:10 +0000, Yevgeny Petrilin wrote:
> > >
> > > This is an abuse of the ethtool_drvinfo::driver field.
> > >
> > > Your users can use lspci -v, can't they?
> > >
> > I don't think there is a problem here.
> > We have always reported the HW model via Ethtool, we just expanded the information
> > we provide.
> > Our users prefer to see the information in ethtool.
>
> Do you mean 'we documented ethtool -i as the way to get hardware
> identification'? That would be a bug in your documentation.
We need consistency among drivers in these fields.
next prev parent reply other threads:[~2011-03-23 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 8:38 [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i Yevgeny Petrilin
2011-03-23 14:04 ` Ben Hutchings
2011-03-23 15:10 ` Yevgeny Petrilin
2011-03-23 15:46 ` Ben Hutchings
2011-03-23 15:54 ` Yevgeny Petrilin
2011-03-23 16:08 ` Ben Hutchings
2011-03-23 17:06 ` Stephen Hemminger
2011-03-23 15:58 ` Stephen Hemminger [this message]
2011-03-23 19:36 ` David Miller
2011-03-24 3:40 ` Ben Hutchings
2011-03-24 6:26 ` Yevgeny Petrilin
2011-03-23 19:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323085815.0a2cbcb0@nehalam \
--to=shemminger@vyatta.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eugenia@mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.