From: John Stultz <john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Richard Cochran <richardcochran-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Krzysztof Halasa <khc-9GfyWEdoJtJmR6Xm/wNWPw@public.gmane.org>,
Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Rodolfo Giometti <giometti-k2GhghHVRtY@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>,
Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Subject: Re: [PATCH V12 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER.
Date: Wed, 23 Mar 2011 14:46:25 -0700 [thread overview]
Message-ID: <1300916785.848.54.camel@work-vm> (raw)
In-Reply-To: <f8af215ebe32a8c0f4b3a82b8ee7e8008b4feb1e.1298878618.git.richard.cochran-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
On Mon, 2011-02-28 at 08:58 +0100, Richard Cochran wrote:
> This patch adds support for the PTP clock found on the DP83640.
> The basic clock operations and one external time stamp have
> been implemented.
Just locking rule comment nits here.
> +static int tdr_write(int bc, struct phy_device *dev,
> + const struct timespec *ts, u16 cmd)
> +{
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_nsec & 0xffff);/* ns[15:0] */
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_nsec >> 16); /* ns[31:16] */
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_sec & 0xffff); /* sec[15:0] */
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_sec >> 16); /* sec[31:16]*/
> +
> + ext_write(bc, dev, PAGE4, PTP_CTL, cmd);
> +
> + return 0;
> +}
The above needs to hold the extreg_lock, and should be commented as
such.
And again, the function names are sort of generic, and could use a
dp83640_ prefix or something.
thanks
-john
WARNING: multiple messages have this Message-ID (diff)
From: John Stultz <john.stultz@linaro.org>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Rodolfo Giometti <giometti@linux.it>,
Arnd Bergmann <arnd@arndb.de>,
Peter Zijlstra <peterz@infradead.org>,
linux-api@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
netdev@vger.kernel.org, Mike Frysinger <vapier@gentoo.org>,
Christoph Lameter <cl@linux.com>,
linuxppc-dev@lists.ozlabs.org, David Miller <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
Krzysztof Halasa <khc@pm.waw.pl>
Subject: Re: [PATCH V12 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER.
Date: Wed, 23 Mar 2011 14:46:25 -0700 [thread overview]
Message-ID: <1300916785.848.54.camel@work-vm> (raw)
In-Reply-To: <f8af215ebe32a8c0f4b3a82b8ee7e8008b4feb1e.1298878618.git.richard.cochran@omicron.at>
On Mon, 2011-02-28 at 08:58 +0100, Richard Cochran wrote:
> This patch adds support for the PTP clock found on the DP83640.
> The basic clock operations and one external time stamp have
> been implemented.
Just locking rule comment nits here.
> +static int tdr_write(int bc, struct phy_device *dev,
> + const struct timespec *ts, u16 cmd)
> +{
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_nsec & 0xffff);/* ns[15:0] */
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_nsec >> 16); /* ns[31:16] */
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_sec & 0xffff); /* sec[15:0] */
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_sec >> 16); /* sec[31:16]*/
> +
> + ext_write(bc, dev, PAGE4, PTP_CTL, cmd);
> +
> + return 0;
> +}
The above needs to hold the extreg_lock, and should be commented as
such.
And again, the function names are sort of generic, and could use a
dp83640_ prefix or something.
thanks
-john
WARNING: multiple messages have this Message-ID (diff)
From: john.stultz@linaro.org (John Stultz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V12 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER.
Date: Wed, 23 Mar 2011 14:46:25 -0700 [thread overview]
Message-ID: <1300916785.848.54.camel@work-vm> (raw)
In-Reply-To: <f8af215ebe32a8c0f4b3a82b8ee7e8008b4feb1e.1298878618.git.richard.cochran@omicron.at>
On Mon, 2011-02-28 at 08:58 +0100, Richard Cochran wrote:
> This patch adds support for the PTP clock found on the DP83640.
> The basic clock operations and one external time stamp have
> been implemented.
Just locking rule comment nits here.
> +static int tdr_write(int bc, struct phy_device *dev,
> + const struct timespec *ts, u16 cmd)
> +{
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_nsec & 0xffff);/* ns[15:0] */
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_nsec >> 16); /* ns[31:16] */
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_sec & 0xffff); /* sec[15:0] */
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_sec >> 16); /* sec[31:16]*/
> +
> + ext_write(bc, dev, PAGE4, PTP_CTL, cmd);
> +
> + return 0;
> +}
The above needs to hold the extreg_lock, and should be commented as
such.
And again, the function names are sort of generic, and could use a
dp83640_ prefix or something.
thanks
-john
WARNING: multiple messages have this Message-ID (diff)
From: John Stultz <john.stultz@linaro.org>
To: Richard Cochran <richardcochran@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Christoph Lameter <cl@linux.com>,
David Miller <davem@davemloft.net>,
Krzysztof Halasa <khc@pm.waw.pl>,
Peter Zijlstra <peterz@infradead.org>,
Rodolfo Giometti <giometti@linux.it>,
Thomas Gleixner <tglx@linutronix.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Mike Frysinger <vapier@gentoo.org>,
Paul Mackerras <paulus@samba.org>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH V12 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER.
Date: Wed, 23 Mar 2011 14:46:25 -0700 [thread overview]
Message-ID: <1300916785.848.54.camel@work-vm> (raw)
In-Reply-To: <f8af215ebe32a8c0f4b3a82b8ee7e8008b4feb1e.1298878618.git.richard.cochran@omicron.at>
On Mon, 2011-02-28 at 08:58 +0100, Richard Cochran wrote:
> This patch adds support for the PTP clock found on the DP83640.
> The basic clock operations and one external time stamp have
> been implemented.
Just locking rule comment nits here.
> +static int tdr_write(int bc, struct phy_device *dev,
> + const struct timespec *ts, u16 cmd)
> +{
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_nsec & 0xffff);/* ns[15:0] */
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_nsec >> 16); /* ns[31:16] */
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_sec & 0xffff); /* sec[15:0] */
> + ext_write(bc, dev, PAGE4, PTP_TDR, ts->tv_sec >> 16); /* sec[31:16]*/
> +
> + ext_write(bc, dev, PAGE4, PTP_CTL, cmd);
> +
> + return 0;
> +}
The above needs to hold the extreg_lock, and should be commented as
such.
And again, the function names are sort of generic, and could use a
dp83640_ prefix or something.
thanks
-john
next prev parent reply other threads:[~2011-03-23 21:46 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 7:57 [PATCH V12 0/4] ptp: IEEE 1588 hardware clock support Richard Cochran
2011-02-28 7:57 ` Richard Cochran
2011-02-28 7:57 ` Richard Cochran
2011-02-28 7:57 ` Richard Cochran
2011-02-28 7:57 ` [PATCH V12 1/4] ptp: Added a brand new class driver for ptp clocks Richard Cochran
2011-02-28 7:57 ` Richard Cochran
2011-02-28 7:57 ` Richard Cochran
2011-03-23 21:19 ` John Stultz
2011-03-23 21:19 ` John Stultz
2011-03-23 21:19 ` John Stultz
2011-03-26 13:12 ` Richard Cochran
2011-03-26 13:12 ` Richard Cochran
2011-03-26 13:12 ` Richard Cochran
2011-03-26 13:12 ` Richard Cochran
2011-02-28 7:57 ` [PATCH V12 2/4] ptp: Added a clock that uses the eTSEC found on the MPC85xx Richard Cochran
2011-02-28 7:57 ` Richard Cochran
2011-02-28 7:57 ` Richard Cochran
[not found] ` <aa97e94c82ebd8953d83b53f64cbfef66c81b7be.1298878618.git.richard.cochran-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
2011-03-23 21:30 ` John Stultz
2011-03-23 21:30 ` John Stultz
2011-03-23 21:30 ` John Stultz
2011-03-23 21:30 ` John Stultz
2011-03-26 13:23 ` Richard Cochran
2011-03-26 13:23 ` Richard Cochran
2011-03-26 13:23 ` Richard Cochran
2011-03-26 13:23 ` Richard Cochran
[not found] ` <cover.1298878618.git.richard.cochran-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
2011-02-28 7:58 ` [PATCH V12 3/4] ptp: Added a clock driver for the IXP46x Richard Cochran
2011-02-28 7:58 ` Richard Cochran
2011-02-28 7:58 ` Richard Cochran
2011-02-28 7:58 ` Richard Cochran
[not found] ` <cd6ddff0dcca60ac88b35660505d7bf54ad32405.1298878618.git.richard.cochran-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
2011-03-13 23:40 ` Krzysztof Halasa
2011-03-13 23:40 ` Krzysztof Halasa
2011-03-13 23:40 ` Krzysztof Halasa
2011-03-13 23:40 ` Krzysztof Halasa
2011-03-23 21:43 ` John Stultz
2011-03-23 21:43 ` John Stultz
2011-03-23 21:43 ` John Stultz
2011-02-28 7:58 ` [PATCH V12 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER Richard Cochran
2011-02-28 7:58 ` Richard Cochran
2011-02-28 7:58 ` Richard Cochran
2011-02-28 7:58 ` Richard Cochran
[not found] ` <f8af215ebe32a8c0f4b3a82b8ee7e8008b4feb1e.1298878618.git.richard.cochran-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
2011-03-23 21:46 ` John Stultz [this message]
2011-03-23 21:46 ` John Stultz
2011-03-23 21:46 ` John Stultz
2011-03-23 21:46 ` John Stultz
2011-03-26 13:40 ` Richard Cochran
2011-03-26 13:40 ` Richard Cochran
2011-03-26 13:40 ` Richard Cochran
2011-03-26 13:40 ` Richard Cochran
2011-03-03 20:13 ` [PATCH V12 0/4] ptp: IEEE 1588 hardware clock support David Miller
2011-03-03 20:13 ` David Miller
2011-03-03 20:13 ` David Miller
2011-03-03 20:13 ` David Miller
2011-03-16 14:26 ` Richard Cochran
2011-03-16 14:26 ` Richard Cochran
2011-03-16 14:26 ` Richard Cochran
2011-03-16 14:26 ` Richard Cochran
2011-03-19 10:14 ` Richard Cochran
2011-03-19 10:14 ` Richard Cochran
2011-03-19 10:14 ` Richard Cochran
2011-03-19 10:14 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300916785.848.54.camel@work-vm \
--to=john.stultz-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=giometti-k2GhghHVRtY@public.gmane.org \
--cc=khc-9GfyWEdoJtJmR6Xm/wNWPw@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=richardcochran-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.