All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linuxppc-dev@ozlabs.org, Anton Blanchard <anton@au1.ibm.com>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	WANG Cong <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH 1/2] kdump: Allow shrinking of kdump region to be overridden
Date: Thu, 24 Mar 2011 15:33:30 +1100	[thread overview]
Message-ID: <1300941210.2402.414.camel@pasglop> (raw)
In-Reply-To: <im6fj2$576$1@dough.gmane.org>

On Mon, 2011-03-21 at 03:10 +0000, WANG Cong wrote:
> On Tue, 15 Mar 2011 22:22:19 +0530, Mahesh J Salgaonkar wrote:

> >> Okay, but with this patch applied, we will just ignore rtas region,
> >> right?
> > Correct.
> >> Thus, when I echo 0 to free all the 128M crashkernel memory, the final
> >> result will be 32M left, which means crash_size will still show 32M.
> >> This looks odd.
> >> 
> >> How about skipping the 32M as a whole? I mean once the region being
> >> freed has overlap with this rtas region, skip the whole rtas region,
> >> and let crash_size
> >> show 0?
> > The existing code from crash_shrink_memory() function reduces the crash
> > size to 0 when echo'ed 0. I did test this patchset and verified that
> > /sys/kernel/kexec_crash_size show 0 value.
> 
> Oh, ok.
> 
> Acked-by: WANG Cong <xiyou.wangcong@gmail.com>

So Eric, what's the right approach to get that merged ? This is a bug
gating an important delivery for us, and the patch doesn't appear
terribly invasive ? :-)

I can send it to Linus myself if you prefer and give me your Ack.

Cheers,
Ben.



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linuxppc-dev@ozlabs.org, Anton Blanchard <anton@au1.ibm.com>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	WANG Cong <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH 1/2] kdump: Allow shrinking of kdump region to be overridden
Date: Thu, 24 Mar 2011 15:33:30 +1100	[thread overview]
Message-ID: <1300941210.2402.414.camel@pasglop> (raw)
In-Reply-To: <im6fj2$576$1@dough.gmane.org>

On Mon, 2011-03-21 at 03:10 +0000, WANG Cong wrote:
> On Tue, 15 Mar 2011 22:22:19 +0530, Mahesh J Salgaonkar wrote:

> >> Okay, but with this patch applied, we will just ignore rtas region,
> >> right?
> > Correct.
> >> Thus, when I echo 0 to free all the 128M crashkernel memory, the final
> >> result will be 32M left, which means crash_size will still show 32M.
> >> This looks odd.
> >> 
> >> How about skipping the 32M as a whole? I mean once the region being
> >> freed has overlap with this rtas region, skip the whole rtas region,
> >> and let crash_size
> >> show 0?
> > The existing code from crash_shrink_memory() function reduces the crash
> > size to 0 when echo'ed 0. I did test this patchset and verified that
> > /sys/kernel/kexec_crash_size show 0 value.
> 
> Oh, ok.
> 
> Acked-by: WANG Cong <xiyou.wangcong@gmail.com>

So Eric, what's the right approach to get that merged ? This is a bug
gating an important delivery for us, and the patch doesn't appear
terribly invasive ? :-)

I can send it to Linus myself if you prefer and give me your Ack.

Cheers,
Ben.

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
	linuxppc-dev@ozlabs.org, WANG Cong <xiyou.wangcong@gmail.com>,
	Anton Blanchard <anton@au1.ibm.com>
Subject: Re: [PATCH 1/2] kdump: Allow shrinking of kdump region to be overridden
Date: Thu, 24 Mar 2011 15:33:30 +1100	[thread overview]
Message-ID: <1300941210.2402.414.camel@pasglop> (raw)
In-Reply-To: <im6fj2$576$1@dough.gmane.org>

On Mon, 2011-03-21 at 03:10 +0000, WANG Cong wrote:
> On Tue, 15 Mar 2011 22:22:19 +0530, Mahesh J Salgaonkar wrote:

> >> Okay, but with this patch applied, we will just ignore rtas region,
> >> right?
> > Correct.
> >> Thus, when I echo 0 to free all the 128M crashkernel memory, the final
> >> result will be 32M left, which means crash_size will still show 32M.
> >> This looks odd.
> >> 
> >> How about skipping the 32M as a whole? I mean once the region being
> >> freed has overlap with this rtas region, skip the whole rtas region,
> >> and let crash_size
> >> show 0?
> > The existing code from crash_shrink_memory() function reduces the crash
> > size to 0 when echo'ed 0. I did test this patchset and verified that
> > /sys/kernel/kexec_crash_size show 0 value.
> 
> Oh, ok.
> 
> Acked-by: WANG Cong <xiyou.wangcong@gmail.com>

So Eric, what's the right approach to get that merged ? This is a bug
gating an important delivery for us, and the patch doesn't appear
terribly invasive ? :-)

I can send it to Linus myself if you prefer and give me your Ack.

Cheers,
Ben.



  reply	other threads:[~2011-03-24  4:33 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-25  0:22 [PATCH 1/2] kdump: Allow shrinking of kdump region to be overridden Anton Blanchard
2010-08-25  0:22 ` Anton Blanchard
2010-08-25  0:22 ` Anton Blanchard
2010-08-25  0:23 ` [PATCH 2/2] powerpc: kdump: Override crash_free_reserved_phys_range to avoid freeing RTAS Anton Blanchard
2010-08-25  0:23   ` Anton Blanchard
2010-08-25  0:23   ` Anton Blanchard
2010-08-25  0:37 ` [PATCH 1/2] kdump: Allow shrinking of kdump region to be overridden Eric W. Biederman
2010-08-25  0:37   ` Eric W. Biederman
2010-08-25  0:37   ` Eric W. Biederman
2011-03-09  6:32   ` Mahesh Jagannath Salgaonkar
2011-03-09  6:32     ` Mahesh Jagannath Salgaonkar
2011-03-09  6:32     ` Mahesh Jagannath Salgaonkar
2011-03-09 12:20     ` Américo Wang
2011-03-09 12:20       ` Américo Wang
2011-03-09 12:20       ` Américo Wang
2011-03-09 12:46       ` Anton Blanchard
2011-03-09 12:46         ` Anton Blanchard
2011-03-09 12:46         ` Anton Blanchard
2011-03-09 14:21         ` Américo Wang
2011-03-09 14:21           ` Américo Wang
2011-03-09 14:21           ` Américo Wang
2011-03-14 18:13           ` Mahesh J Salgaonkar
2011-03-14 18:13             ` Mahesh J Salgaonkar
2011-03-14 18:13             ` Mahesh J Salgaonkar
2011-03-15  7:52             ` Américo Wang
2011-03-15  7:52               ` Américo Wang
2011-03-15  7:52               ` Américo Wang
2011-03-15 16:52               ` Mahesh J Salgaonkar
2011-03-15 16:52                 ` Mahesh J Salgaonkar
2011-03-15 16:52                 ` Mahesh J Salgaonkar
2011-03-21  3:10                 ` WANG Cong
2011-03-21  3:10                   ` WANG Cong
2011-03-24  4:33                   ` Benjamin Herrenschmidt [this message]
2011-03-24  4:33                     ` Benjamin Herrenschmidt
2011-03-24  4:33                     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300941210.2402.414.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=anton@au1.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.