All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Greg KH <greg@kroah.com>
Subject: Re: [PATCH] mac80211: rename RX_FLAG_TSFT
Date: Thu, 24 Mar 2011 14:37:25 +0100	[thread overview]
Message-ID: <1300973845.26265.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <op.vsunv6ae3ri7v4@arend-laptop>

Hi Arend,

> > +#if 0
> > +	/* Clearly, this is bogus -- reading the TSF now is wrong */
> >  	wlc_read_tsf(wlc, &tsf_l, &tsf_h);	/* mactime */
> >  	rx_status->mactime = tsf_h;
> >  	rx_status->mactime <<= 32;
> >  	rx_status->mactime |= tsf_l;
> > -	rx_status->flag |= RX_FLAG_TSFT;
> > +	rx_status->flag |= RX_FLAG_MACTIME_MPDU; /* clearly wrong */
> > +#endif
> 
> This piece of code has been '#if 0'-ed by you. Could you elaborate why  
> this is clearly wrong? Because of this the variables tsf_l and tsf_h are  
> not being used hence the warning.

include/net/mac80211.h:

 * @mactime: value in microseconds of the 64-bit Time Synchronization Function
 *      (TSF) timer when the first data symbol (MPDU) arrived at the hardware.


Not sure what else to say ... reading the TSF when processing the frame
in software is clearly bogus.

johannes



  reply	other threads:[~2011-03-24 13:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-23 14:06 [PATCH] mac80211: rename RX_FLAG_TSFT Johannes Berg
2011-03-24 13:32 ` Arend van Spriel
2011-03-24 13:37   ` Johannes Berg [this message]
2011-03-24 14:22     ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300973845.26265.4.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend@broadcom.com \
    --cc=greg@kroah.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.