All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "John Linville" <linville@tuxdriver.com>,
	"Johannes Berg" <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	"Greg KH" <greg@kroah.com>
Subject: Re: [PATCH] mac80211: rename RX_FLAG_TSFT
Date: Thu, 24 Mar 2011 14:32:20 +0100	[thread overview]
Message-ID: <op.vsunv6ae3ri7v4@arend-laptop> (raw)
In-Reply-To: <1298469968.4122.8.camel@jlt3.sipsolutions.net>

On Wed, 23 Feb 2011 15:06:08 +0100, Johannes Berg  
<johannes@sipsolutions.net> wrote:

>  drivers/staging/brcm80211/sys/wlc_mac80211.c  |    5 ++++-

Hi Johannes,

2.6.38 has landed in staging-2.6 repository and I built our driver. It  
gives build warning on above mentioned file.

>
> --- wireless-testing.orig/include/net/mac80211.h	2011-02-23  
> -	RX_FLAG_TSFT		= 1<<7,
> +	RX_FLAG_MACTIME_MPDU	= 1<<7,

> wireless-testing.orig/drivers/staging/brcm80211/sys/wlc_mac80211.c	2011-02-23  
> 15:03:58.000000000 +0100
> +++  
> wireless-testing/drivers/staging/brcm80211/sys/wlc_mac80211.c	2011-02-23  
> 15:04:48.000000000 +0100
> @@ -6818,11 +6818,14 @@ prep_mac80211_status(struct wlc_info *wl
>  	ratespec_t rspec;
>  	unsigned char *plcp;
> +#if 0
> +	/* Clearly, this is bogus -- reading the TSF now is wrong */
>  	wlc_read_tsf(wlc, &tsf_l, &tsf_h);	/* mactime */
>  	rx_status->mactime = tsf_h;
>  	rx_status->mactime <<= 32;
>  	rx_status->mactime |= tsf_l;
> -	rx_status->flag |= RX_FLAG_TSFT;
> +	rx_status->flag |= RX_FLAG_MACTIME_MPDU; /* clearly wrong */
> +#endif

This piece of code has been '#if 0'-ed by you. Could you elaborate why  
this is clearly wrong? Because of this the variables tsf_l and tsf_h are  
not being used hence the warning.

Gr. AvS
-- 
"The most merciful thing in the world, I think, is the inability of the  
human
mind to correlate all its contents." - "The Call of Cthulhu"


  reply	other threads:[~2011-03-24 13:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-23 14:06 [PATCH] mac80211: rename RX_FLAG_TSFT Johannes Berg
2011-03-24 13:32 ` Arend van Spriel [this message]
2011-03-24 13:37   ` Johannes Berg
2011-03-24 14:22     ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.vsunv6ae3ri7v4@arend-laptop \
    --to=arend@broadcom.com \
    --cc=greg@kroah.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.