From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Russell King <linux@arm.linux.org.uk>,
l-o <linux-omap@vger.kernel.org>,
lak <linux-arm-kernel@lists.infradead.org>,
sricharan <r.sricharan@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Felipe Balbi <balbi@ti.com>, Benoit Cousson <b-cousson@ti.com>,
Omar Ramirez Luna <omar.ramirez@ti.com>
Subject: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
Date: Fri, 25 Mar 2011 18:29:56 -0600 [thread overview]
Message-ID: <1301099396-30380-1-git-send-email-omar.ramirez@ti.com> (raw)
If an error occurs in the L3 on any other initiator than MPU,
the interrupt goes unhandled given that the 'base' register
was calculated with the initialized err_base value (which
coincidentally points to MPU) and not with the actual source
of the error.
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
arch/arm/mach-omap2/omap_l3_smx.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-omap2/omap_l3_smx.c
index 5f2da75..da917c2 100644
--- a/arch/arm/mach-omap2/omap_l3_smx.c
+++ b/arch/arm/mach-omap2/omap_l3_smx.c
@@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
/* No timeout error for debug sources */
}
- base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
-
/* identify the error source */
for (err_source = 0; !(status & (1 << err_source)); err_source++)
;
+
+ base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
+
error = omap3_l3_readll(base, L3_ERROR_LOG);
if (error) {
--
1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: omar.ramirez@ti.com (Omar Ramirez Luna)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
Date: Fri, 25 Mar 2011 18:29:56 -0600 [thread overview]
Message-ID: <1301099396-30380-1-git-send-email-omar.ramirez@ti.com> (raw)
If an error occurs in the L3 on any other initiator than MPU,
the interrupt goes unhandled given that the 'base' register
was calculated with the initialized err_base value (which
coincidentally points to MPU) and not with the actual source
of the error.
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
arch/arm/mach-omap2/omap_l3_smx.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-omap2/omap_l3_smx.c
index 5f2da75..da917c2 100644
--- a/arch/arm/mach-omap2/omap_l3_smx.c
+++ b/arch/arm/mach-omap2/omap_l3_smx.c
@@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
/* No timeout error for debug sources */
}
- base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
-
/* identify the error source */
for (err_source = 0; !(status & (1 << err_source)); err_source++)
;
+
+ base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
+
error = omap3_l3_readll(base, L3_ERROR_LOG);
if (error) {
--
1.7.1
next reply other threads:[~2011-03-26 0:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 0:29 Omar Ramirez Luna [this message]
2011-03-26 0:29 ` [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message Omar Ramirez Luna
2011-03-26 0:44 ` Ramirez Luna, Omar
2011-03-26 0:44 ` Ramirez Luna, Omar
2011-03-26 21:38 ` Sergei Shtylyov
2011-03-26 21:38 ` Sergei Shtylyov
2011-03-28 1:49 ` Ramirez Luna, Omar
2011-03-28 1:49 ` Ramirez Luna, Omar
2011-03-28 8:27 ` Sergei Shtylyov
2011-03-28 8:27 ` Sergei Shtylyov
2011-03-28 1:30 ` Felipe Contreras
2011-03-28 1:30 ` Felipe Contreras
2011-03-28 1:47 ` Ramirez Luna, Omar
2011-03-28 1:47 ` Ramirez Luna, Omar
2011-03-28 5:38 ` Santosh Shilimkar
2011-03-28 5:38 ` Santosh Shilimkar
2011-03-28 15:15 ` Ramirez Luna, Omar
2011-03-28 15:15 ` Ramirez Luna, Omar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301099396-30380-1-git-send-email-omar.ramirez@ti.com \
--to=omar.ramirez@ti.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=r.sricharan@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.