All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Collins <collinsd@codeaurora.org>
To: Liam Girdwood <lrg@slimlogic.co.uk>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm-owner@vger.kernel.org,
	David Collins <collinsd@codeaurora.org>
Subject: [PATCH v2 0/2] regulator: Fix regulator_enable deadlock and add uA_load propagation
Date: Mon, 28 Mar 2011 16:52:35 -0700	[thread overview]
Message-ID: <1301356355-7546-1-git-send-email-collinsd@codeaurora.org> (raw)
In-Reply-To: <1301326482-6547-1-git-send-email-collinsd@codeaurora.org>

Because the uA_load propagation change takes out a lock on a regulator and
then the regulators that it supplies, it will cause deadlock with the current
regulator_enable implementation.  regulator_disable can also deadlock with
regulator_enable, but it requires two threads and precise timing to observe.
Therefore, regulator_enable must be fixed before current propagation can be
used.

Changes from v1:
	- Renamed _regulator_enable to regulator_dev_enable.
	- Made change logs more verbose.

David Collins (2):
  regulator: Remove possible deadlock from regulator_enable
  regulator: Propagate uA_load requirements up supply chain

 drivers/regulator/core.c         |  151 ++++++++++++++++++++++++++++++-------
 include/linux/regulator/driver.h |    5 +
 2 files changed, 127 insertions(+), 29 deletions(-)

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: collinsd@codeaurora.org (David Collins)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/2] regulator: Fix regulator_enable deadlock and add uA_load propagation
Date: Mon, 28 Mar 2011 16:52:35 -0700	[thread overview]
Message-ID: <1301356355-7546-1-git-send-email-collinsd@codeaurora.org> (raw)
In-Reply-To: <1301326482-6547-1-git-send-email-collinsd@codeaurora.org>

Because the uA_load propagation change takes out a lock on a regulator and
then the regulators that it supplies, it will cause deadlock with the current
regulator_enable implementation.  regulator_disable can also deadlock with
regulator_enable, but it requires two threads and precise timing to observe.
Therefore, regulator_enable must be fixed before current propagation can be
used.

Changes from v1:
	- Renamed _regulator_enable to regulator_dev_enable.
	- Made change logs more verbose.

David Collins (2):
  regulator: Remove possible deadlock from regulator_enable
  regulator: Propagate uA_load requirements up supply chain

 drivers/regulator/core.c         |  151 ++++++++++++++++++++++++++++++-------
 include/linux/regulator/driver.h |    5 +
 2 files changed, 127 insertions(+), 29 deletions(-)

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  parent reply	other threads:[~2011-03-28 23:52 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-28 15:34 [PATCH 0/2] regulator: Fix regulator_enable deadlock and add uA_load propagation David Collins
2011-03-28 15:34 ` David Collins
2011-03-28 15:34 ` [PATCH 1/2] regulator: Remove possible deadlock from regulator_enable David Collins
2011-03-28 15:34   ` David Collins
2011-03-28 18:11   ` Mark Brown
2011-03-28 18:11     ` Mark Brown
2011-03-28 18:22     ` David Collins
2011-03-28 18:22       ` David Collins
2011-03-28 15:34 ` [PATCH 2/2] regulator: Propagate uA_load requirements up supply chain David Collins
2011-03-28 15:34   ` David Collins
2011-03-28 18:02   ` Mark Brown
2011-03-28 18:02     ` Mark Brown
2011-03-28 18:14     ` Russell King - ARM Linux
2011-03-28 18:14       ` Russell King - ARM Linux
2011-03-29  7:53       ` Mark Brown
2011-03-29  7:53         ` Mark Brown
2011-03-29  8:28         ` Russell King - ARM Linux
2011-03-29  8:28           ` Russell King - ARM Linux
2011-03-29  8:40           ` Mark Brown
2011-03-29  8:40             ` Mark Brown
2011-03-28 18:18     ` David Collins
2011-03-28 18:18       ` David Collins
2011-03-28 18:33       ` broonie@gmail.com
2011-03-28 18:33         ` broonie@gmail.com
2011-03-28 23:52 ` David Collins [this message]
2011-03-28 23:52   ` [PATCH v2 0/2] regulator: Fix regulator_enable deadlock and add uA_load propagation David Collins
2011-03-28 23:53   ` [PATCH v2 1/2] regulator: Remove possible deadlock from regulator_enable David Collins
2011-03-28 23:53     ` David Collins
2011-03-28 23:53   ` [PATCH v2 2/2] regulator: Propagate uA_load requirements up supply chain David Collins
2011-03-28 23:53     ` David Collins
2011-03-29  8:44     ` Mark Brown
2011-03-29  8:44       ` Mark Brown
2011-03-29 16:08       ` David Collins
2011-03-29 16:08         ` David Collins
2011-03-29 21:20         ` Mark Brown
2011-03-29 21:20           ` Mark Brown
2011-03-30  1:00           ` Mark Brown
2011-03-30  1:00             ` Mark Brown
2011-03-29 22:40     ` Mark Brown
2011-03-29 22:40       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1301356355-7546-1-git-send-email-collinsd@codeaurora.org \
    --to=collinsd@codeaurora.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm-owner@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.