All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@citrix.com>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 2 of 2] xen: hvm_save: Add pre-3.4 compatibility for hvm_hw_cpu
Date: Fri, 01 Apr 2011 12:13:55 +0100	[thread overview]
Message-ID: <1301656435.9447.79.camel@elijah> (raw)
In-Reply-To: <1301654976.27123.207.camel@zakaz.uk.xensource.com>

On Fri, 2011-04-01 at 11:49 +0100, Ian Campbell wrote:
> On Thu, 2011-03-31 at 15:21 +0100, George Dunlap wrote:
> > @@ -46,6 +46,8 @@
> >  
> >  /*
> >   * Processor
> > + *
> > + * Compat: Pre-3.4 didn't have msr_tsc_aux
> 
> Do you mean Pre-4.0? i.e. 3.4 and earlier?

Yes, I noticed that a bit too late. :-)

> 
> >   */
> >  
> >  struct hvm_hw_cpu {
> > @@ -157,8 +159,131 @@
> >      uint32_t error_code;
> >  };
> >  
> > -DECLARE_HVM_SAVE_TYPE(CPU, 2, struct hvm_hw_cpu);
> > +struct hvm_hw_cpu_compat { 
> 
> "struct hvm_hw_cpu_3_4_compat" to make it clear which version compat is
> with?

Sounds like a good idea.  If Tim thinks it's worth including, I'll spin
up another series.

 -George

  reply	other threads:[~2011-04-01 11:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-31 14:21 [PATCH 0 of 2] RFC: hvm_save backwards compatibility George Dunlap
2011-03-31 14:21 ` [PATCH 1 of 2] xen: hvm_save: infrastructure for " George Dunlap
2011-03-31 14:21 ` [PATCH 2 of 2] xen: hvm_save: Add pre-3.4 compatibility for hvm_hw_cpu George Dunlap
2011-04-01 10:49   ` Ian Campbell
2011-04-01 11:13     ` George Dunlap [this message]
2011-04-06 10:54   ` Tim Deegan
2011-04-01 10:23 ` [PATCH 0 of 2] RFC: hvm_save backwards compatibility Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1301656435.9447.79.camel@elijah \
    --to=george.dunlap@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.