From: Artem Bityutskiy <dedekind1@gmail.com>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, Ralph Hempel <ralph.hempel@lantiq.com>,
linux-mtd@lists.infradead.org,
Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH V6] MIPS: lantiq: add NOR flash support
Date: Tue, 05 Apr 2011 15:15:51 +0300 [thread overview]
Message-ID: <1302005751.2760.116.camel@localhost> (raw)
In-Reply-To: <1302005720-8508-1-git-send-email-blogic@openwrt.org>
On Tue, 2011-04-05 at 14:15 +0200, John Crispin wrote:
> +int __init
> +init_ltq_mtd(void)
> +{
> + int ret = platform_driver_probe(<q_mtd_driver, ltq_mtd_probe);
> +
> + if (ret)
> + pr_err(KERN_INFO "ltq_nor: error registering platfom driver");
Sorry, but pr_err is defined as follows:
#define pr_err(fmt, ...) \
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
You should not add KERN_INFO.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: John Crispin <blogic@openwrt.org>
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
Ralph Hempel <ralph.hempel@lantiq.com>,
linux-mtd@lists.infradead.org,
Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH V6] MIPS: lantiq: add NOR flash support
Date: Tue, 05 Apr 2011 15:15:51 +0300 [thread overview]
Message-ID: <1302005751.2760.116.camel@localhost> (raw)
In-Reply-To: <1302005720-8508-1-git-send-email-blogic@openwrt.org>
On Tue, 2011-04-05 at 14:15 +0200, John Crispin wrote:
> +int __init
> +init_ltq_mtd(void)
> +{
> + int ret = platform_driver_probe(<q_mtd_driver, ltq_mtd_probe);
> +
> + if (ret)
> + pr_err(KERN_INFO "ltq_nor: error registering platfom driver");
Sorry, but pr_err is defined as follows:
#define pr_err(fmt, ...) \
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
You should not add KERN_INFO.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-04-05 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 12:15 [PATCH V6] MIPS: lantiq: add NOR flash support John Crispin
2011-04-05 12:15 ` John Crispin
2011-04-05 12:15 ` Artem Bityutskiy [this message]
2011-04-05 12:15 ` Artem Bityutskiy
2011-04-05 12:21 ` John Crispin
2011-04-05 12:21 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302005751.2760.116.camel@localhost \
--to=dedekind1@gmail.com \
--cc=blogic@openwrt.org \
--cc=daniel.schwierzeck@googlemail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=ralf@linux-mips.org \
--cc=ralph.hempel@lantiq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.