From: Philippe Gerum <rpm@xenomai.org>
To: Sebastian Smolorz <smolorz@domain.hid>
Cc: adeos-main <adeos-main@gna.org>
Subject: Re: [Adeos-main] [PATCH] x86: fix ipipe tracer
Date: Tue, 05 Apr 2011 16:08:18 +0200 [thread overview]
Message-ID: <1302012498.2084.58.camel@domain.hid> (raw)
In-Reply-To: <201104051603.53977.smolorz@domain.hid>
On Tue, 2011-04-05 at 16:03 +0200, Sebastian Smolorz wrote:
> The ipipe tracer was broken when CONFIG_IPIPE_TRACE_IRQSOFF was
> enabled. The reason was that in local_irq_restore_hw(flags)
> native irqs were not enabled again.
>
> Signed-off-by: Sebastian Smolorz <smolorz@domain.hid>
> ---
> arch/x86/include/asm/irqflags.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/include/asm/irqflags.h
> b/arch/x86/include/asm/irqflags.h
> index ddfd8cc..6e316c0 100644
> --- a/arch/x86/include/asm/irqflags.h
> +++ b/arch/x86/include/asm/irqflags.h
> @@ -283,7 +283,7 @@ static inline int irqs_disabled_hw(void)
> #define local_irq_restore_hw(flags) do { \
> if ((flags) & X86_EFLAGS_IF) \
> ipipe_trace_end(0x80000001); \
> - native_irq_disable(); \
> + native_restore_fl(flags); \
> } while (0)
>
> #else /* !CONFIG_IPIPE_TRACE_IRQSOFF */
Queued, thanks.
--
Philippe.
prev parent reply other threads:[~2011-04-05 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 14:03 [Adeos-main] [PATCH] x86: fix ipipe tracer Sebastian Smolorz
2011-04-05 14:08 ` Philippe Gerum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302012498.2084.58.camel@domain.hid \
--to=rpm@xenomai.org \
--cc=adeos-main@gna.org \
--cc=smolorz@domain.hid \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.