* [Adeos-main] [PATCH] x86: fix ipipe tracer
@ 2011-04-05 14:03 Sebastian Smolorz
2011-04-05 14:08 ` Philippe Gerum
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Smolorz @ 2011-04-05 14:03 UTC (permalink / raw)
To: adeos-main
The ipipe tracer was broken when CONFIG_IPIPE_TRACE_IRQSOFF was
enabled. The reason was that in local_irq_restore_hw(flags)
native irqs were not enabled again.
Signed-off-by: Sebastian Smolorz <smolorz@domain.hid>
---
arch/x86/include/asm/irqflags.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/include/asm/irqflags.h
b/arch/x86/include/asm/irqflags.h
index ddfd8cc..6e316c0 100644
--- a/arch/x86/include/asm/irqflags.h
+++ b/arch/x86/include/asm/irqflags.h
@@ -283,7 +283,7 @@ static inline int irqs_disabled_hw(void)
#define local_irq_restore_hw(flags) do { \
if ((flags) & X86_EFLAGS_IF) \
ipipe_trace_end(0x80000001); \
- native_irq_disable(); \
+ native_restore_fl(flags); \
} while (0)
#else /* !CONFIG_IPIPE_TRACE_IRQSOFF */
--
1.5.2.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Adeos-main] [PATCH] x86: fix ipipe tracer
2011-04-05 14:03 [Adeos-main] [PATCH] x86: fix ipipe tracer Sebastian Smolorz
@ 2011-04-05 14:08 ` Philippe Gerum
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Gerum @ 2011-04-05 14:08 UTC (permalink / raw)
To: Sebastian Smolorz; +Cc: adeos-main
On Tue, 2011-04-05 at 16:03 +0200, Sebastian Smolorz wrote:
> The ipipe tracer was broken when CONFIG_IPIPE_TRACE_IRQSOFF was
> enabled. The reason was that in local_irq_restore_hw(flags)
> native irqs were not enabled again.
>
> Signed-off-by: Sebastian Smolorz <smolorz@domain.hid>
> ---
> arch/x86/include/asm/irqflags.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/include/asm/irqflags.h
> b/arch/x86/include/asm/irqflags.h
> index ddfd8cc..6e316c0 100644
> --- a/arch/x86/include/asm/irqflags.h
> +++ b/arch/x86/include/asm/irqflags.h
> @@ -283,7 +283,7 @@ static inline int irqs_disabled_hw(void)
> #define local_irq_restore_hw(flags) do { \
> if ((flags) & X86_EFLAGS_IF) \
> ipipe_trace_end(0x80000001); \
> - native_irq_disable(); \
> + native_restore_fl(flags); \
> } while (0)
>
> #else /* !CONFIG_IPIPE_TRACE_IRQSOFF */
Queued, thanks.
--
Philippe.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-05 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-05 14:03 [Adeos-main] [PATCH] x86: fix ipipe tracer Sebastian Smolorz
2011-04-05 14:08 ` Philippe Gerum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.