From: "Michael Büsch" <mb@bu3sch.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Joe Perches <joe@perches.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Arend van Spriel <arend@broadcom.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
George Kashperko <george@znau.edu.ua>,
b43-dev@lists.infradead.org
Subject: [RFC][PATCH] bcmai: introduce AI driver
Date: Tue, 05 Apr 2011 22:25:06 +0200 [thread overview]
Message-ID: <1302035106.1923.7.camel@maggie> (raw)
In-Reply-To: <BANLkTimTmqop-xzFsWr1=2RXv5z6iTre4Q@mail.gmail.com> (sfid-20110405_221605_148029_FFFFFFFFFD5E0FFF)
On Tue, 2011-04-05 at 22:15 +0200, Rafa? Mi?ecki wrote:
> Some more reviews, please? Should I drop that prefix, is Joe right?
Yes.
> >> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
> > []
> >> +/* AI core, see drivers/bcmai/ */
> >> +struct bcmai_device_id {
> >> + __u16 manuf;
> >> + __u16 id;
> >> + __u8 rev;
> >> +};
> >
> > Do some of these structs need __packed declarations?
>
> I was reading about __packed long time ago and it was a little tricky
> for me. However I don't see anything in mod_devicetable.h using that
> __packed. Why should we?
I don't think packed is needed here.
Just note that this struct is ABI. So it's written in stone if merged.
--
Greetings Michael.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <mb@bu3sch.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Joe Perches <joe@perches.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Arend van Spriel <arend@broadcom.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
George Kashperko <george@znau.edu.ua>,
b43-dev@lists.infradead.org
Subject: Re: [RFC][PATCH] bcmai: introduce AI driver
Date: Tue, 05 Apr 2011 22:25:06 +0200 [thread overview]
Message-ID: <1302035106.1923.7.camel@maggie> (raw)
In-Reply-To: <BANLkTimTmqop-xzFsWr1=2RXv5z6iTre4Q@mail.gmail.com> (sfid-20110405_221605_148029_FFFFFFFFFD5E0FFF)
On Tue, 2011-04-05 at 22:15 +0200, Rafał Miłecki wrote:
> Some more reviews, please? Should I drop that prefix, is Joe right?
Yes.
> >> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
> > []
> >> +/* AI core, see drivers/bcmai/ */
> >> +struct bcmai_device_id {
> >> + __u16 manuf;
> >> + __u16 id;
> >> + __u8 rev;
> >> +};
> >
> > Do some of these structs need __packed declarations?
>
> I was reading about __packed long time ago and it was a little tricky
> for me. However I don't see anything in mod_devicetable.h using that
> __packed. Why should we?
I don't think packed is needed here.
Just note that this struct is ABI. So it's written in stone if merged.
--
Greetings Michael.
next prev parent reply other threads:[~2011-04-05 20:25 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 19:57 [RFC][PATCH] bcmai: introduce AI driver Rafał Miłecki
2011-04-05 19:57 ` Rafał Miłecki
2011-04-05 19:25 ` Rafał Miłecki
2011-04-05 19:25 ` Rafał Miłecki
2011-04-05 19:29 ` Michael Büsch
2011-04-05 19:29 ` Michael Büsch
2011-04-05 19:35 ` Joe Perches
2011-04-05 20:15 ` Rafał Miłecki
2011-04-05 20:15 ` Rafał Miłecki
2011-04-05 20:25 ` Michael Büsch [this message]
2011-04-05 20:25 ` Michael Büsch
2011-04-05 22:30 ` [PATCH] ssb: Use pr_fmt and pr_<level>, remove CONFIG_SSB_SILENT Joe Perches
2011-04-05 20:37 ` [RFC][PATCH] bcmai: introduce AI driver Joe Perches
2011-04-05 20:50 ` Larry Finger
2011-04-05 20:50 ` Larry Finger
2011-04-06 14:18 ` Arend van Spriel
2011-04-06 14:18 ` Arend van Spriel
2011-04-06 18:02 ` Rafał Miłecki
2011-04-06 18:02 ` Rafał Miłecki
2011-04-06 18:02 ` Rafał Miłecki
2011-04-06 20:25 ` Arend van Spriel
2011-04-06 20:25 ` Arend van Spriel
2011-04-06 20:40 ` Rafał Miłecki
2011-04-06 20:40 ` Rafał Miłecki
2011-04-06 20:40 ` Rafał Miłecki
2011-04-06 20:42 ` Rafał Miłecki
2011-04-06 20:42 ` Rafał Miłecki
2011-04-06 20:42 ` Rafał Miłecki
2011-04-06 20:57 ` Michael Büsch
2011-04-06 20:57 ` Michael Büsch
2011-04-06 20:57 ` Michael Büsch
2011-04-06 21:01 ` Rafał Miłecki
2011-04-06 21:01 ` Rafał Miłecki
2011-04-06 21:01 ` Rafał Miłecki
2011-04-06 21:08 ` Michael Büsch
2011-04-06 21:08 ` Michael Büsch
2011-04-06 21:08 ` Michael Büsch
2011-04-06 21:12 ` Rafał Miłecki
2011-04-06 21:12 ` Rafał Miłecki
2011-04-06 21:12 ` Rafał Miłecki
2011-04-06 21:18 ` George Kashperko
2011-04-06 21:18 ` George Kashperko
2011-04-06 23:20 ` Rafał Miłecki
2011-04-06 23:20 ` Rafał Miłecki
2011-04-06 23:20 ` Rafał Miłecki
2011-04-07 0:00 ` George Kashperko
2011-04-07 0:00 ` George Kashperko
2011-04-07 0:54 ` Rafał Miłecki
2011-04-07 0:54 ` Rafał Miłecki
2011-04-07 0:54 ` Rafał Miłecki
2011-04-07 1:02 ` George Kashperko
2011-04-07 1:02 ` George Kashperko
2011-04-07 7:54 ` Michael Büsch
2011-04-07 7:54 ` Michael Büsch
2011-04-07 7:54 ` Michael Büsch
2011-04-07 8:58 ` Arend van Spriel
2011-04-07 8:58 ` Arend van Spriel
2011-04-07 18:50 ` George Kashperko
2011-04-07 18:50 ` George Kashperko
2011-04-07 9:55 ` Rafał Miłecki
2011-04-07 9:55 ` Rafał Miłecki
2011-04-07 9:55 ` Rafał Miłecki
2011-04-07 18:36 ` George Kashperko
2011-04-07 18:36 ` George Kashperko
2011-04-06 21:20 ` Michael Büsch
2011-04-06 21:20 ` Michael Büsch
2011-04-06 21:20 ` Michael Büsch
2011-04-08 16:56 ` Rafał Miłecki
2011-04-08 16:56 ` Rafał Miłecki
2011-04-08 16:56 ` Rafał Miłecki
2011-04-08 17:09 ` Rafał Miłecki
2011-04-08 17:09 ` Rafał Miłecki
2011-04-08 17:09 ` Rafał Miłecki
2011-04-08 17:14 ` Rafał Miłecki
2011-04-08 17:14 ` Rafał Miłecki
2011-04-08 17:14 ` Rafał Miłecki
2011-04-08 17:24 ` Arend van Spriel
2011-04-08 17:24 ` Arend van Spriel
2011-04-08 17:27 ` Rafał Miłecki
2011-04-08 17:27 ` Rafał Miłecki
2011-04-08 17:27 ` Rafał Miłecki
2011-04-08 17:28 ` Arend van Spriel
2011-04-08 17:28 ` Arend van Spriel
2011-04-08 17:31 ` Rafał Miłecki
2011-04-08 17:31 ` Rafał Miłecki
2011-04-08 17:31 ` Rafał Miłecki
2011-04-09 7:10 ` George Kashperko
2011-04-09 7:10 ` George Kashperko
2011-04-09 11:01 ` Arend van Spriel
2011-04-09 11:01 ` Arend van Spriel
2011-04-10 8:01 ` Pavel Machek
2011-04-10 8:01 ` Pavel Machek
2011-04-10 8:05 ` Rafał Miłecki
2011-04-10 8:05 ` Rafał Miłecki
2011-04-10 8:05 ` Rafał Miłecki
2011-04-10 8:24 ` Pavel Machek
2011-04-10 8:24 ` Pavel Machek
2011-04-10 8:30 ` Rafał Miłecki
2011-04-10 8:30 ` Rafał Miłecki
2011-04-10 8:30 ` Rafał Miłecki
2011-04-10 9:33 ` Arend van Spriel
2011-04-10 9:33 ` Arend van Spriel
2011-04-10 11:32 ` Rafał Miłecki
2011-04-10 11:32 ` Rafał Miłecki
2011-04-10 11:32 ` Rafał Miłecki
2011-04-10 14:36 ` Arend van Spriel
2011-04-10 14:36 ` Arend van Spriel
2011-04-10 16:11 ` George Kashperko
2011-04-10 16:11 ` George Kashperko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302035106.1923.7.camel@maggie \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=arend@broadcom.com \
--cc=b43-dev@lists.infradead.org \
--cc=george@znau.edu.ua \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.