From: Chris Mason <chris.mason@oracle.com>
To: Arne Jansen <sensille@gmx.net>
Cc: Josef Bacik <josef@redhat.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: don't kzalloc the ordered extents
Date: Wed, 06 Apr 2011 07:06:16 -0400 [thread overview]
Message-ID: <1302087945-sup-6943@think> (raw)
In-Reply-To: <4D9C1C1F.8090208@gmx.net>
Excerpts from Arne Jansen's message of 2011-04-06 03:54:07 -0400:
> On 06.04.2011 01:20, Josef Bacik wrote:
> > We initialize almost all of the fields when we allocate an ordered extent, so
> > use kmalloc instead of kzalloc and just initialize the other fields that we
> > don't already initialize yet. Thanks,
>
> Is it really worth it? we have seen a few bugs in the past resulting
> from uninitialized structure element, that even made it to disk.
> Using kzalloc makes maintenance much easier.
I'm a big kzalloc fan unless this particular caller shows up in
benchmarks. Josef how much did this one help?
-chris
next prev parent reply other threads:[~2011-04-06 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 23:20 [PATCH] Btrfs: don't kzalloc the ordered extents Josef Bacik
2011-04-06 7:54 ` Arne Jansen
2011-04-06 11:06 ` Chris Mason [this message]
2011-04-06 15:24 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302087945-sup-6943@think \
--to=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sensille@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.