Re: [PATCH] Btrfs: don't kzalloc the ordered extents

[Josef Bacik <josef@redhat.com>]

On 04/06/2011 07:06 AM, Chris Mason wrote:
> Excerpts from Arne Jansen's message of 2011-04-06 03:54:07 -0400:
>> On 06.04.2011 01:20, Josef Bacik wrote:
>>> We initialize almost all of the fields when we allocate an ordered extent, so
>>> use kmalloc instead of kzalloc and just initialize the other fields that we
>>> don't already initialize yet.  Thanks,
>> Is it really worth it? we have seen a few bugs in the past resulting
>> from uninitialized structure element, that even made it to disk.
>> Using kzalloc makes maintenance much easier.
> I'm a big kzalloc fan unless this particular caller shows up in
> benchmarks.  Josef how much did this one help?
>
> -chris
.1 mb/s, give or take .1 mb/s :).  Just low hanging fruit since we're 
already doing all the initialization anyway, but it's up to you, kind of 
just was fixing everything I could get my hands on :).  Thanks,

Josef