From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Timur Tabi <timur@freescale.com>,
Andi Kleen <andi@firstfloor.org>, Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] make new alloc_pages_exact()
Date: Fri, 08 Apr 2011 15:06:16 -0700 [thread overview]
Message-ID: <1302300376.7286.1392.camel@nimitz> (raw)
In-Reply-To: <op.vtmcx9kd3l0zgt@mnazarewicz-glaptop>
On Fri, 2011-04-08 at 14:28 +0200, Michal Nazarewicz wrote:
> On Thu, 07 Apr 2011 19:21:05 +0200, Dave Hansen <dave@linux.vnet.ibm.com>
> > + struct page *alloc_end = page + (1 << order);
> > + struct page *used = page + PAGE_ALIGN(size)/PAGE_SIZE;
> > - split_page(virt_to_page((void *)addr), order);
> > + split_page(page, order);
> > while (used < alloc_end) {
> > - free_page(used);
> > - used += PAGE_SIZE;
> > + __free_page(used);
> > + used++;
> > }
>
> Have you thought about moving this loop to a separate function, ie.
> _free_page_range(start, end)? I'm asking because this loop appears
> in two places and my CMA would also benefit from such a function.
It's actually perilously close to free_pages_exact(). I'll try to make
it usable for this case as well.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Timur Tabi <timur@freescale.com>,
Andi Kleen <andi@firstfloor.org>, Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] make new alloc_pages_exact()
Date: Fri, 08 Apr 2011 15:06:16 -0700 [thread overview]
Message-ID: <1302300376.7286.1392.camel@nimitz> (raw)
In-Reply-To: <op.vtmcx9kd3l0zgt@mnazarewicz-glaptop>
On Fri, 2011-04-08 at 14:28 +0200, Michal Nazarewicz wrote:
> On Thu, 07 Apr 2011 19:21:05 +0200, Dave Hansen <dave@linux.vnet.ibm.com>
> > + struct page *alloc_end = page + (1 << order);
> > + struct page *used = page + PAGE_ALIGN(size)/PAGE_SIZE;
> > - split_page(virt_to_page((void *)addr), order);
> > + split_page(page, order);
> > while (used < alloc_end) {
> > - free_page(used);
> > - used += PAGE_SIZE;
> > + __free_page(used);
> > + used++;
> > }
>
> Have you thought about moving this loop to a separate function, ie.
> _free_page_range(start, end)? I'm asking because this loop appears
> in two places and my CMA would also benefit from such a function.
It's actually perilously close to free_pages_exact(). I'll try to make
it usable for this case as well.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-08 22:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 17:21 [PATCH 1/2] rename alloc_pages_exact() Dave Hansen
2011-04-07 17:21 ` Dave Hansen
2011-04-07 17:21 ` [PATCH 2/2] make new alloc_pages_exact() Dave Hansen
2011-04-07 17:21 ` Dave Hansen
2011-04-07 22:03 ` David Rientjes
2011-04-07 22:03 ` David Rientjes
2011-04-07 22:17 ` Dave Hansen
2011-04-07 22:17 ` Dave Hansen
2011-04-08 12:28 ` Michal Nazarewicz
2011-04-08 12:28 ` Michal Nazarewicz
2011-04-08 13:19 ` Dave Hansen
2011-04-08 13:19 ` Dave Hansen
2011-04-08 13:23 ` Michal Nazarewicz
2011-04-08 13:23 ` Michal Nazarewicz
2011-04-08 22:06 ` Dave Hansen [this message]
2011-04-08 22:06 ` Dave Hansen
2011-04-07 21:40 ` [PATCH 1/2] rename alloc_pages_exact() David Rientjes
2011-04-07 21:40 ` David Rientjes
2011-04-07 21:58 ` Dave Hansen
2011-04-07 21:58 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302300376.7286.1392.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mina86@mina86.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.