From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/3] hwmon: (sht15) general code clean-up
Date: Mon, 11 Apr 2011 19:03:25 +0000 [thread overview]
Message-ID: <1302547369-sup-2609@sfl> (raw)
In-Reply-To: <1302198246-22212-2-git-send-email-vivien.didelot@savoirfairelinux.com>
Excerpts from Jonathan Cameron's message of 2011-04-08 14:17:54 -0400:
> My one question on this is in the header. Why the extra indent?
> Maybe it looks a smigeon clearer but I'm far from convinced by that
> bit.
The extra indentation in the clean-up patch is made to align the
existing attributes (or macros) with the new ones introduced in the
following patchs, which have longer names (such as
SHT15_STATUS_LOW_BATTERY or last_measurement).
> I agree most of yours are clearer. Measurements rather than
> measures would be even better.
ok, I've changed measures for measurements.
> Also, I'd have preferred to see the fixes separated out from the
> purely superficial name changes etc. They are both worth while, but
> only one changes what actually happens in the driver!
I agree. I've separated the probe function clean-up into a separated
patch.
Vivien.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-04-11 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 17:44 [lm-sensors] [PATCH 1/3] hwmon: (sht15) general code clean-up Vivien Didelot
2011-04-08 18:17 ` Jonathan Cameron
2011-04-11 19:03 ` Vivien Didelot [this message]
2011-04-12 8:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302547369-sup-2609@sfl \
--to=vivien.didelot@savoirfairelinux.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.