All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/3] hwmon: (sht15) general code clean-up
Date: Tue, 12 Apr 2011 08:02:05 +0000	[thread overview]
Message-ID: <4DA406FD.70103@cam.ac.uk> (raw)
In-Reply-To: <1302198246-22212-2-git-send-email-vivien.didelot@savoirfairelinux.com>

On 04/11/11 20:03, Vivien Didelot wrote:
> Excerpts from Jonathan Cameron's message of 2011-04-08 14:17:54 -0400:
>> My one question on this is in the header.  Why the extra indent?
>> Maybe it looks a smigeon clearer but I'm far from convinced by that
>> bit.
> 
> The extra indentation in the clean-up patch is made to align the
> existing attributes (or macros) with the new ones introduced in the
> following patchs, which have longer names (such as
> SHT15_STATUS_LOW_BATTERY or last_measurement).
Fair enough. It might ideally have occurred in that patch as then the
reason would have been obvious!

Still, it's to early in the morning and I'm just being fussy ;)


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2011-04-12  8:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-07 17:44 [lm-sensors] [PATCH 1/3] hwmon: (sht15) general code clean-up Vivien Didelot
2011-04-08 18:17 ` Jonathan Cameron
2011-04-11 19:03 ` Vivien Didelot
2011-04-12  8:02 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA406FD.70103@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.