* [PATCH 1/3] ASoC: fsi: take care in failing case of dai register
2011-04-08 6:08 [PATCH 0/3] ASoC: fsi: bug fix for driver probe/remove Kuninori Morimoto
@ 2011-04-08 6:09 ` Kuninori Morimoto
2011-04-08 6:09 ` [PATCH 2/3] ASoC: fsi: modify vague PM control on probe Kuninori Morimoto
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2011-04-08 6:09 UTC (permalink / raw)
To: Mark Brown; +Cc: yoshii, Linux-ALSA, Simon, Magnus, Liam Girdwood
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
sound/soc/sh/fsi.c | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
index 0c9997e..8e51a6e 100644
--- a/sound/soc/sh/fsi.c
+++ b/sound/soc/sh/fsi.c
@@ -1218,8 +1218,17 @@ static int fsi_probe(struct platform_device *pdev)
goto exit_free_irq;
}
- return snd_soc_register_dais(&pdev->dev, fsi_soc_dai, ARRAY_SIZE(fsi_soc_dai));
+ ret = snd_soc_register_dais(&pdev->dev, fsi_soc_dai,
+ ARRAY_SIZE(fsi_soc_dai));
+ if (ret < 0) {
+ dev_err(&pdev->dev, "cannot snd dai register\n");
+ goto exit_snd_soc;
+ }
+ return ret;
+
+exit_snd_soc:
+ snd_soc_unregister_platform(&pdev->dev);
exit_free_irq:
free_irq(irq, master);
exit_iounmap:
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/3] ASoC: fsi: modify vague PM control on probe
2011-04-08 6:08 [PATCH 0/3] ASoC: fsi: bug fix for driver probe/remove Kuninori Morimoto
2011-04-08 6:09 ` [PATCH 1/3] ASoC: fsi: take care in failing case of dai register Kuninori Morimoto
@ 2011-04-08 6:09 ` Kuninori Morimoto
2011-04-08 6:09 ` Kuninori Morimoto
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2011-04-08 6:09 UTC (permalink / raw)
To: Mark Brown; +Cc: yoshii, Linux-ALSA, Simon, Magnus, Liam Girdwood
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
sound/soc/sh/fsi.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
index 8e51a6e..8071bc6 100644
--- a/sound/soc/sh/fsi.c
+++ b/sound/soc/sh/fsi.c
@@ -1200,10 +1200,11 @@ static int fsi_probe(struct platform_device *pdev)
master->fsib.master = master;
pm_runtime_enable(&pdev->dev);
- pm_runtime_resume(&pdev->dev);
dev_set_drvdata(&pdev->dev, master);
+ pm_runtime_get_sync(&pdev->dev);
fsi_soft_all_reset(master);
+ pm_runtime_put_sync(&pdev->dev);
ret = request_irq(irq, &fsi_interrupt, IRQF_DISABLED,
id_entry->name, master);
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/3] ASoC: fsi: modify vague PM control on probe
2011-04-08 6:08 [PATCH 0/3] ASoC: fsi: bug fix for driver probe/remove Kuninori Morimoto
2011-04-08 6:09 ` [PATCH 1/3] ASoC: fsi: take care in failing case of dai register Kuninori Morimoto
2011-04-08 6:09 ` [PATCH 2/3] ASoC: fsi: modify vague PM control on probe Kuninori Morimoto
@ 2011-04-08 6:09 ` Kuninori Morimoto
2011-04-08 6:09 ` [PATCH 3/3] ASoC: fsi: driver safely remove for against irq Kuninori Morimoto
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2011-04-08 6:09 UTC (permalink / raw)
To: Mark Brown; +Cc: yoshii, Linux-ALSA, Simon, Magnus, Liam Girdwood
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
sound/soc/sh/fsi.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
index 8e51a6e..8071bc6 100644
--- a/sound/soc/sh/fsi.c
+++ b/sound/soc/sh/fsi.c
@@ -1200,10 +1200,11 @@ static int fsi_probe(struct platform_device *pdev)
master->fsib.master = master;
pm_runtime_enable(&pdev->dev);
- pm_runtime_resume(&pdev->dev);
dev_set_drvdata(&pdev->dev, master);
+ pm_runtime_get_sync(&pdev->dev);
fsi_soft_all_reset(master);
+ pm_runtime_put_sync(&pdev->dev);
ret = request_irq(irq, &fsi_interrupt, IRQF_DISABLED,
id_entry->name, master);
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 3/3] ASoC: fsi: driver safely remove for against irq
2011-04-08 6:08 [PATCH 0/3] ASoC: fsi: bug fix for driver probe/remove Kuninori Morimoto
` (2 preceding siblings ...)
2011-04-08 6:09 ` Kuninori Morimoto
@ 2011-04-08 6:09 ` Kuninori Morimoto
2011-04-08 6:09 ` Kuninori Morimoto
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2011-04-08 6:09 UTC (permalink / raw)
To: Mark Brown; +Cc: yoshii, Linux-ALSA, Simon, Magnus, Liam Girdwood
free_irq and pm_runtime_disable should be called before
snd_soc_unregister_xxx
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
sound/soc/sh/fsi.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
index 8071bc6..5843158 100644
--- a/sound/soc/sh/fsi.c
+++ b/sound/soc/sh/fsi.c
@@ -1248,12 +1248,11 @@ static int fsi_remove(struct platform_device *pdev)
master = dev_get_drvdata(&pdev->dev);
- snd_soc_unregister_dais(&pdev->dev, ARRAY_SIZE(fsi_soc_dai));
- snd_soc_unregister_platform(&pdev->dev);
-
+ free_irq(master->irq, master);
pm_runtime_disable(&pdev->dev);
- free_irq(master->irq, master);
+ snd_soc_unregister_dais(&pdev->dev, ARRAY_SIZE(fsi_soc_dai));
+ snd_soc_unregister_platform(&pdev->dev);
iounmap(master->base);
kfree(master);
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 3/3] ASoC: fsi: driver safely remove for against irq
2011-04-08 6:08 [PATCH 0/3] ASoC: fsi: bug fix for driver probe/remove Kuninori Morimoto
` (3 preceding siblings ...)
2011-04-08 6:09 ` [PATCH 3/3] ASoC: fsi: driver safely remove for against irq Kuninori Morimoto
@ 2011-04-08 6:09 ` Kuninori Morimoto
2011-04-11 19:50 ` [PATCH 0/3] ASoC: fsi: bug fix for driver probe/remove Liam Girdwood
2011-04-11 20:16 ` Mark Brown
6 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2011-04-08 6:09 UTC (permalink / raw)
To: Mark Brown; +Cc: yoshii, Linux-ALSA, Simon, Magnus, Liam Girdwood
free_irq and pm_runtime_disable should be called before
snd_soc_unregister_xxx
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
sound/soc/sh/fsi.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
index 8071bc6..5843158 100644
--- a/sound/soc/sh/fsi.c
+++ b/sound/soc/sh/fsi.c
@@ -1248,12 +1248,11 @@ static int fsi_remove(struct platform_device *pdev)
master = dev_get_drvdata(&pdev->dev);
- snd_soc_unregister_dais(&pdev->dev, ARRAY_SIZE(fsi_soc_dai));
- snd_soc_unregister_platform(&pdev->dev);
-
+ free_irq(master->irq, master);
pm_runtime_disable(&pdev->dev);
- free_irq(master->irq, master);
+ snd_soc_unregister_dais(&pdev->dev, ARRAY_SIZE(fsi_soc_dai));
+ snd_soc_unregister_platform(&pdev->dev);
iounmap(master->base);
kfree(master);
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 0/3] ASoC: fsi: bug fix for driver probe/remove
2011-04-08 6:08 [PATCH 0/3] ASoC: fsi: bug fix for driver probe/remove Kuninori Morimoto
` (4 preceding siblings ...)
2011-04-08 6:09 ` Kuninori Morimoto
@ 2011-04-11 19:50 ` Liam Girdwood
2011-04-11 20:16 ` Mark Brown
6 siblings, 0 replies; 8+ messages in thread
From: Liam Girdwood @ 2011-04-11 19:50 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: yoshii, Linux-ALSA, Mark Brown, Magnus, Simon
On Fri, 2011-04-08 at 15:08 +0900, Kuninori Morimoto wrote:
> Dear Mark, Liam
>
> These are bug fix patches for FSI driver probe/remove
>
> Kuninori Morimoto (3)
> ASoC: fsi: take care in failing case of dai register
> ASoC: fsi: modify vague PM control on probe
> ASoC: fsi: driver safely remove for against irq
>
> Magnus
>
> Can you please check #2 patch which modify pm_runtime
>
All
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 0/3] ASoC: fsi: bug fix for driver probe/remove
2011-04-08 6:08 [PATCH 0/3] ASoC: fsi: bug fix for driver probe/remove Kuninori Morimoto
` (5 preceding siblings ...)
2011-04-11 19:50 ` [PATCH 0/3] ASoC: fsi: bug fix for driver probe/remove Liam Girdwood
@ 2011-04-11 20:16 ` Mark Brown
6 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2011-04-11 20:16 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: yoshii, Linux-ALSA, Simon, Magnus, Liam Girdwood
On Fri, Apr 08, 2011 at 03:08:17PM +0900, Kuninori Morimoto wrote:
>
> Dear Mark, Liam
>
> These are bug fix patches for FSI driver probe/remove
Applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread