All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: torvalds <torvalds@linux-foundation.org>
Cc: akpm <akpm@linux-foundation.org>,
	"Luck, Tony" <tony.luck@intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	xfs@oss.sgi.com
Subject: [PATCH] xfs_destroy_workqueues() should not be tagged with __exit
Date: Mon, 11 Apr 2011 16:48:19 -0500	[thread overview]
Message-ID: <1302558499.2580.96.camel@doink> (raw)

Linus, please apply the following patch, which fixes
a problem with ia64 builds that is present in the XFS
pull request I sent you this morning.  Thank you.

					-Alex

-------- Forwarded Message --------
From: Luck, Tony <tony.luck@intel.com>
To: xfs-masters@oss.sgi.com
Cc: hch@lst.de, dchinner@redhat.com, aelder@sgi.com
Subject: [PATCH] xfs_destroy_workqueues() should not be tagged with
__exit
Date: Mon, 11 Apr 2011 12:06:12 -0700

ia64 throws away .exit sections for the built-in CONFIG case, so routines
that are used in other circumstances should not be tagged as __exit.

Signed-off-by: Tony Luck <tony.luck@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>

---

Should be applied after (or merged into) Dave Chinner's patch
	xfs: convert the xfsaild threads to a workqueue
which appeared as commit 0bf6a5bd4b55b466964ead6fa566d8f346a828ee in
next-20110411

diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c
index 67d5b2c..b38e58d 100644
--- a/fs/xfs/linux-2.6/xfs_super.c
+++ b/fs/xfs/linux-2.6/xfs_super.c
@@ -1741,7 +1741,7 @@ out:
 	return -ENOMEM;
 }
 
-STATIC void __exit
+STATIC void
 xfs_destroy_workqueues(void)
 {
 	destroy_workqueue(xfs_ail_wq);


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Alex Elder <aelder@sgi.com>
To: torvalds <torvalds@linux-foundation.org>
Cc: akpm <akpm@linux-foundation.org>,
	xfs@oss.sgi.com, linux-kernel <linux-kernel@vger.kernel.org>,
	"Luck, Tony" <tony.luck@intel.com>
Subject: [PATCH] xfs_destroy_workqueues() should not be tagged with __exit
Date: Mon, 11 Apr 2011 16:48:19 -0500	[thread overview]
Message-ID: <1302558499.2580.96.camel@doink> (raw)

Linus, please apply the following patch, which fixes
a problem with ia64 builds that is present in the XFS
pull request I sent you this morning.  Thank you.

					-Alex

-------- Forwarded Message --------
From: Luck, Tony <tony.luck@intel.com>
To: xfs-masters@oss.sgi.com
Cc: hch@lst.de, dchinner@redhat.com, aelder@sgi.com
Subject: [PATCH] xfs_destroy_workqueues() should not be tagged with
__exit
Date: Mon, 11 Apr 2011 12:06:12 -0700

ia64 throws away .exit sections for the built-in CONFIG case, so routines
that are used in other circumstances should not be tagged as __exit.

Signed-off-by: Tony Luck <tony.luck@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>

---

Should be applied after (or merged into) Dave Chinner's patch
	xfs: convert the xfsaild threads to a workqueue
which appeared as commit 0bf6a5bd4b55b466964ead6fa566d8f346a828ee in
next-20110411

diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c
index 67d5b2c..b38e58d 100644
--- a/fs/xfs/linux-2.6/xfs_super.c
+++ b/fs/xfs/linux-2.6/xfs_super.c
@@ -1741,7 +1741,7 @@ out:
 	return -ENOMEM;
 }
 
-STATIC void __exit
+STATIC void
 xfs_destroy_workqueues(void)
 {
 	destroy_workqueue(xfs_ail_wq);



             reply	other threads:[~2011-04-11 21:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-11 21:48 Alex Elder [this message]
2011-04-11 21:48 ` [PATCH] xfs_destroy_workqueues() should not be tagged with __exit Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302558499.2580.96.camel@doink \
    --to=aelder@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.