From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Hugh Dickins <hughd@google.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: mm: convert vma->vm_flags to 64bit
Date: Wed, 13 Apr 2011 18:56:59 +1000 [thread overview]
Message-ID: <1302685019.28876.80.camel@pasglop> (raw)
In-Reply-To: <20110413072935.GK7806@n2100.arm.linux.org.uk>
On Wed, 2011-04-13 at 08:29 +0100, Russell King - ARM Linux wrote:
>
> > Right, it shouldn't. My original patch did that to avoid thinking
> about
> > archs that manipulated it from asm such as ARM but that wasn't the
> right
> > thing to do. But that doesn't invalidate having a type.
>
> No, we don't manipulate it. We only test for VM_EXEC in it in asm.
Yeah whatever, you did something that I didn't spare the brain cell to
try to figure out back then :-) Maybe I should have ... I was also
worried about the embedded folks having a go at me for "bloat they don't
need". But in the end it was wrong, it should always be 64-bit.
But regardless, I still think it should be a specific type. "unsigned
long long" really sucks.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Hugh Dickins <hughd@google.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: mm: convert vma->vm_flags to 64bit
Date: Wed, 13 Apr 2011 18:56:59 +1000 [thread overview]
Message-ID: <1302685019.28876.80.camel@pasglop> (raw)
In-Reply-To: <20110413072935.GK7806@n2100.arm.linux.org.uk>
On Wed, 2011-04-13 at 08:29 +0100, Russell King - ARM Linux wrote:
>
> > Right, it shouldn't. My original patch did that to avoid thinking
> about
> > archs that manipulated it from asm such as ARM but that wasn't the
> right
> > thing to do. But that doesn't invalidate having a type.
>
> No, we don't manipulate it. We only test for VM_EXEC in it in asm.
Yeah whatever, you did something that I didn't spare the brain cell to
try to figure out back then :-) Maybe I should have ... I was also
worried about the embedded folks having a go at me for "bloat they don't
need". But in the end it was wrong, it should always be 64-bit.
But regardless, I still think it should be a specific type. "unsigned
long long" really sucks.
Cheers,
Ben.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-13 8:57 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 6:10 mm: convert vma->vm_flags to 64bit KOSAKI Motohiro
2011-04-12 6:10 ` KOSAKI Motohiro
2011-04-12 6:33 ` Andrew Morton
2011-04-12 6:33 ` Andrew Morton
2011-04-12 7:12 ` KOSAKI Motohiro
2011-04-12 7:12 ` KOSAKI Motohiro
2011-04-12 11:06 ` Alexey Dobriyan
2011-04-12 11:06 ` Alexey Dobriyan
2011-04-12 11:11 ` Alexey Dobriyan
2011-04-12 11:11 ` Alexey Dobriyan
2011-04-12 22:07 ` Benjamin Herrenschmidt
2011-04-12 22:07 ` Benjamin Herrenschmidt
2011-04-13 0:13 ` KOSAKI Motohiro
2011-04-13 0:13 ` KOSAKI Motohiro
2011-04-13 6:44 ` Alexey Dobriyan
2011-04-13 6:44 ` Alexey Dobriyan
2011-04-13 7:00 ` Benjamin Herrenschmidt
2011-04-13 7:00 ` Benjamin Herrenschmidt
2011-04-13 7:29 ` Russell King - ARM Linux
2011-04-13 7:29 ` Russell King - ARM Linux
2011-04-13 8:56 ` Benjamin Herrenschmidt [this message]
2011-04-13 8:56 ` Benjamin Herrenschmidt
2011-04-13 8:34 ` KOSAKI Motohiro
2011-04-13 8:34 ` KOSAKI Motohiro
2011-04-13 7:04 ` KOSAKI Motohiro
2011-04-13 7:04 ` KOSAKI Motohiro
2011-04-12 23:41 ` KOSAKI Motohiro
2011-04-12 23:41 ` KOSAKI Motohiro
2011-04-13 2:19 ` [PATCH 1/3] mm: add __nocast attribute to vm_flags KOSAKI Motohiro
2011-04-13 2:19 ` KOSAKI Motohiro
2011-04-13 2:20 ` [PATCH 2/3] fremap: convert vm_flags to unsigned long long KOSAKI Motohiro
2011-04-13 2:20 ` KOSAKI Motohiro
2011-04-13 2:21 ` [PATCH 3/3] procfs: " KOSAKI Motohiro
2011-04-13 2:21 ` KOSAKI Motohiro
2011-04-12 20:30 ` mm: convert vma->vm_flags to 64bit Russell King - ARM Linux
2011-04-12 20:30 ` Russell King - ARM Linux
2011-04-18 0:26 ` Hugh Dickins
2011-04-18 0:26 ` Hugh Dickins
2011-04-18 1:21 ` KOSAKI Motohiro
2011-04-18 1:21 ` KOSAKI Motohiro
2011-04-18 1:45 ` Benjamin Herrenschmidt
2011-04-18 1:45 ` Benjamin Herrenschmidt
2011-04-18 3:34 ` KOSAKI Motohiro
2011-04-18 3:34 ` KOSAKI Motohiro
2011-11-10 4:09 ` Nai Xia
2011-11-10 4:09 ` Nai Xia
2011-11-10 4:49 ` David Rientjes
2011-11-10 4:49 ` David Rientjes
2011-11-11 8:52 ` Russell King - ARM Linux
2011-11-11 8:52 ` Russell King - ARM Linux
2011-11-10 17:22 ` KOSAKI Motohiro
2011-11-10 17:22 ` KOSAKI Motohiro
2011-11-10 21:12 ` Benjamin Herrenschmidt
2011-11-10 21:12 ` Benjamin Herrenschmidt
2011-11-10 21:49 ` KOSAKI Motohiro
2011-11-10 21:49 ` KOSAKI Motohiro
2011-11-11 8:42 ` Russell King - ARM Linux
2011-11-11 8:42 ` Russell King - ARM Linux
2011-11-11 2:09 ` Hugh Dickins
2011-11-11 2:09 ` Hugh Dickins
2011-11-11 4:31 ` Benjamin Herrenschmidt
2011-11-11 4:31 ` Benjamin Herrenschmidt
2011-11-11 8:38 ` Nai Xia
2011-11-11 8:38 ` Nai Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302685019.28876.80.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.